Skip to content

Commit 65db225

Browse files
authored
Touch-up language-picker in side-bar (#1882)
1 parent 99e38f5 commit 65db225

File tree

2 files changed

+26
-7
lines changed

2 files changed

+26
-7
lines changed

frontend/viewer/src/lib/i18n/LocalizationPicker.svelte

Lines changed: 25 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,15 @@
55
import {Icon} from '$lib/components/ui/icon';
66
import {IsMobile} from '$lib/hooks/is-mobile.svelte';
77
import {setLanguage} from '$lib/i18n';
8+
import {SidebarMenuButton} from '$lib/components/ui/sidebar';
9+
10+
type Props = {
11+
inSidebar?: boolean;
12+
};
13+
14+
let {
15+
inSidebar
16+
}: Props = $props();
817
918
const languages: Record<string, string> = {
1019
'en': 'English',
@@ -15,18 +24,28 @@
1524
};
1625
const currentLanguage = $derived(languages[$locale] ?? 'Unknown: ' + $locale);
1726
</script>
27+
1828
<DropdownMenu.Root>
1929
<DropdownMenu.Trigger>
2030
{#snippet child({props})}
21-
<Button {...props} icon="i-mdi-translate" size={IsMobile.value ? 'icon' : undefined} variant="ghost">
22-
{#if !IsMobile.value}
23-
{currentLanguage}
31+
{#if inSidebar}
32+
<SidebarMenuButton {...props}>
33+
<Icon icon="i-mdi-translate" />
34+
<span>{currentLanguage}</span>
35+
<span class="grow"></span>
2436
<Icon icon="i-mdi-menu-down"/>
25-
{/if}
26-
</Button>
37+
</SidebarMenuButton>
38+
{:else}
39+
<Button {...props} icon="i-mdi-translate" size={IsMobile.value ? 'icon' : undefined} variant="ghost">
40+
{#if !IsMobile.value}
41+
{currentLanguage}
42+
<Icon icon="i-mdi-menu-down"/>
43+
{/if}
44+
</Button>
45+
{/if}
2746
{/snippet}
2847
</DropdownMenu.Trigger>
29-
<DropdownMenu.Content>
48+
<DropdownMenu.Content align="end">
3049
<DropdownMenu.RadioGroup bind:value={() => $locale, l => setLanguage(l)}>
3150
{#each Object.entries(languages) as [lang, label] (lang)}
3251
<DropdownMenu.RadioItem class="cursor-pointer" value={lang}>{label}</DropdownMenu.RadioItem>

frontend/viewer/src/project/ProjectSidebar.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@
182182
</Sidebar.MenuButton>
183183
</Sidebar.MenuItem>
184184
<Sidebar.MenuItem>
185-
<LocalizationPicker/>
185+
<LocalizationPicker inSidebar />
186186
</Sidebar.MenuItem>
187187
</Sidebar.Menu>
188188
</Sidebar.Group>

0 commit comments

Comments
 (0)