LT-9222: "***" appearing between inflectional features and values (#318)

* LT-9222: Make default separator be ":"

* LT-9222: Add GetSeparator

* LT-9222: Fix bug in GetSeparator

* Remove spuriously added brackets

Author: jtmaxwell3

src/SIL.LCModel/DomainImpl/OverridesCellar.cs

@@ -2299,17 +2299,22 @@ private string GetFeatureString(bool fLongForm)
 					sFeature = FeatureRA.Abbreviation.BestAnalysisAlternative.Text;
 					if (sFeature == null || sFeature.Length == 0)
 						sFeature = FeatureRA.Name.BestAnalysisAlternative.Text;
-					if (fLongForm)
-						sFeature = sFeature + ":";
-					else
-						sFeature = sFeature + FeatureRA.RightGlossSep.BestAnalysisAlternative.Text;
+					sFeature = sFeature + GetSeparator(FeatureRA, fLongForm);
 				}
 			}
 			else
 				sFeature = m_ksUnknown;
 			return sFeature;
 		}
 
+		internal static string GetSeparator(IFsFeatDefn feature, bool longForm)
+		{
+			string sep = feature.RightGlossSep.BestAnalysisAlternative.Text;
+			if (longForm || sep == "***")
+				return ":";
+			return sep;
+		}
+
 		/// <summary>
 		/// Overridden to handle reference props of this class.
 		/// </summary>
@@ -2526,7 +2531,7 @@ private string GetFeatureString(bool fLongForm)
 					sFeature = FeatureRA.Abbreviation.BestAnalysisAlternative.Text;
 					if (string.IsNullOrEmpty(sFeature))
 						sFeature = FeatureRA.Name.BestAnalysisAlternative.Text;
-					sFeature = fLongForm ? sFeature + ":" : sFeature + FeatureRA.RightGlossSep.BestAnalysisAlternative.Text;
+					sFeature = sFeature + FsClosedValue.GetSeparator(FeatureRA, fLongForm);
 				}
 			}
 			else