Skip to content

Commit ba501bd

Browse files
authored
Fix LT-22205: Consider combining <field> and <field> (Allomorph) (#350)
1 parent 9a2c8b9 commit ba501bd

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/SIL.LCModel/DomainImpl/OverridesLing_Lex.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,7 @@ public IEnumerable<ICmObject> AllPossiblePictures
205205

206206
/// <summary>
207207
/// Gets all the bulk-editable things that might be used as the destination of a bulk edit to
208-
/// Allomorphs. This includes the entries that do not have allomorphs. It does NOT include
209-
/// MoForms that are the LexemeForm of some entry. (Possibly the name should indicate this better somehow?)
208+
/// Allomorphs. This includes MoForms that are the LexemeForm of some entry.
210209
/// </summary>
211210
[VirtualProperty(CellarPropertyType.ReferenceSequence, "CmObject")]
212211
public IEnumerable<ICmObject> AllPossibleAllomorphs
@@ -217,9 +216,7 @@ public IEnumerable<ICmObject> AllPossibleAllomorphs
217216
// Optimize JohnT: are we likely to modify any of the iterators while iterating? If not
218217
// we may not need the ToList().
219218
return (from entry in entries from morph in entry.AlternateFormsOS select morph).Cast<ICmObject>()
220-
.Concat((from entry in entries
221-
where entry.AlternateFormsOS.Count == 0
222-
select entry).Cast<ICmObject>())
219+
.Concat((from entry in entries select entry.LexemeFormOA).Cast<ICmObject>())
223220
.ToList();
224221
}
225222
}

0 commit comments

Comments
 (0)