Skip to content

Commit 0858fd7

Browse files
authored
Merge pull request #1242 from sillsdev/fix/sp-2291-zip-file-size
SP-2291: Set UseZip64WhenSaving to prevent crash with large archives
2 parents e715027 + 3ce8e64 commit 0858fd7

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
3232
- [SIL.DblBundle] Attempting to construct a UsxNode based on an invalid XmlNode now throws an exception in the constructor in most cases rather than later when properties are accessed.
3333
- [SIL.DblBundle] Accessing UsxChapter.ChapterNumber on a chapter end node returns the chapter number (from the eid attribute) instead of throwing an exception.
3434
- [SIL.WritingSystems] Prevent (and clean up) duplicate URLs in LDML files for Fonts, Keyboards, and Spell Check Dictionaries.
35+
- [SIL.Archiving] Set UseZip64WhenSaving to Zip64Option.AsNecessary to prevent crash with large archives
3536

3637
### Changed
3738

SIL.Archiving/RampArchivingDlgViewModel.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1735,6 +1735,7 @@ private void CreateZipFileInWorkerThread(object sender, DoWorkEventArgs e)
17351735
using (var zip = new ZipFile())
17361736
{
17371737
// RAMP packages must not be compressed or RAMP can't read them.
1738+
zip.UseZip64WhenSaving = Zip64Option.AsNecessary; // See SP-2291
17381739
zip.CompressionLevel = Ionic.Zlib.CompressionLevel.None;
17391740
zip.AddFiles(filesToCopyAndZip.Values, @"\");
17401741
zip.AddFile(_metsFilePath, string.Empty);

0 commit comments

Comments
 (0)