fix version to conform to V.V.V.V (#253)

Author: megahirt

.github/workflows/build-test-installer-release.yml

@@ -31,27 +31,28 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Compute version
+      - name: Compute Version
         id: compute_version
-        shell: pwsh
-        env:
-          IS_TAG: ${{ startsWith(github.ref, 'refs/tags/v') }}
-          REF_NAME: ${{ github.ref_name }}
-          HEAD_COMMIT_TIMESTAMP: ${{ github.event.head_commit && github.event.head_commit.timestamp || '' }}
-          GITHUB_SHA: ${{ github.sha }}
+        shell: bash
         run: |
-          if ($env:IS_TAG -eq 'true') {
-            $version = $env:REF_NAME
-          } elseif (-not [string]::IsNullOrEmpty($env:HEAD_COMMIT_TIMESTAMP)) {
-            $timestamp = [DateTime]::Parse($env:HEAD_COMMIT_TIMESTAMP).ToUniversalTime().ToString("yyyyMMddHHmm")
-            $version = "$timestamp-$($env:GITHUB_SHA)"
-          } else {
-            $timestamp = [DateTime]::UtcNow.ToString("yyyyMMddHHmm")
-            $version = "$timestamp-$($env:GITHUB_SHA)"
-          }
-
-          "Version=$version" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
-          "version=$version" | Out-File -FilePath $env:GITHUB_OUTPUT -Encoding utf8 -Append
+          # If this is a tag push and it starts with v, just use it
+          if [[ "${GITHUB_REF}" == refs/tags/v* ]]; then
+            Version="${GITHUB_REF#refs/tags/}"
+            echo "version=$Version" >> $GITHUB_OUTPUT
+            echo "detected tag push: $Version"
+            exit 0
+          fi
+
+          # Otherwise find the latest tag that starts with v
+          LAST_TAG=$(git describe --tags --match "v*" --abbrev=0 2>/dev/null || echo "v0.0.0")
+
+          # Compute a build number based on number of commits since that tag
+          COMMITS_SINCE_TAG=$(git rev-list ${LAST_TAG}..HEAD --count)
+
+          # Final version: vX.Y.Z+<build>
+          Version="${LAST_TAG}.${COMMITS_SINCE_TAG}"
+          echo "version=$Version" >> $GITHUB_OUTPUT
+          echo "no tag push; using $Version"
 
       - name: Setup NuGet
         uses: NuGet/setup-nuget@v2
@@ -68,7 +69,7 @@ jobs:
         run: msbuild build\SayMore.proj /t:Build /p:Configuration=$env:Configuration /p:Version=$env:Version /m
 
       - name: Run tests
-        run: msbuild build\SayMore.proj /t:Test /p:Configuration=$env:Configuration /p:excludedCategories=SkipOnTeamCity /m
+        run: msbuild build\SayMore.proj /t:Test /p:Configuration=$env:Configuration /p:useNUnit-x86=true /p:excludedCategories=SkipOnTeamCity /m
 
       - name: Upload test results
         if: always()

build/SayMore.proj

@@ -32,8 +32,8 @@
 
   <Target Name="VersionNumbers">
 	<PropertyGroup>
-		<!-- The Version should be set from the outside, if not, set a default value -->
-		<Version Condition="'$(Version)' == ''">$([System.DateTime]::Now.ToString("yyyyMMddHHmmss"))</Version>
+		<!-- The Version should be set from the outside, if not, set a meaningless default value -->
+		<Version Condition="'$(Version)' == ''">1.0.0.0</Version>
 	</PropertyGroup>
 
 		<Message Text="Version: $(Version)" Importance="high"/>