Skip to content

Commit fb2885d

Browse files
committed
fix flaky test
This test asserts that the settingsMenuLink is not present, and the appropriate test should be `isPresent()` not `isDisplayed()`
1 parent 8bfaf45 commit fb2885d

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

test/app/bellows/project-settings.e2e-spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ describe('Bellows E2E Project Settings app', () => {
1515
await loginPage.loginAsMember();
1616
await projectsPage.get();
1717
await projectsPage.clickOnProject(constants.testProjectName);
18-
expect<boolean>(await settingsPage.settingsMenuLink.isDisplayed()).toBe(false);
18+
expect<boolean>(await settingsPage.settingsMenuLink.isPresent()).toBe(false);
1919
});
2020

2121
it('System Admin can manage project', async () => {

test/app/languageforge/lexicon/settings/config-fields.e2e-spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ describe('Lexicon E2E Configuration Fields', () => {
3939
});
4040

4141
it('can go to Configuration and select unified Fields tab', async () => {
42-
expect<any>(await configPage.settingsMenuLink.isDisplayed()).toBe(true);
42+
expect<any>(await configPage.settingsMenuLink.isPresent()).toBe(true);
4343
await configPage.get();
4444
expect<any>(await configPage.applyButton.isDisplayed()).toBe(true);
4545
expect<any>(await configPage.applyButton.isEnabled()).toBe(false);

test/app/languageforge/lexicon/settings/config-input-systems.e2e-spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ describe('Lexicon E2E Configuration Input Systems', () => {
1717
await loginPage.loginAsUser();
1818
await projectsPage.get();
1919
await projectsPage.clickOnProject(constants.testProjectName);
20-
expect<boolean>(await configPage.settingsMenuLink.isDisplayed()).toBe(false);
20+
expect<boolean>(await configPage.settingsMenuLink.isPresent()).toBe(false);
2121
});
2222

2323
it('setup: login as manager, select test project, goto configuration', async () => {
2424
await loginPage.loginAsManager();
2525
await projectsPage.get();
2626
await projectsPage.clickOnProject(constants.testProjectName);
27-
expect<any>(await configPage.settingsMenuLink.isDisplayed()).toBe(true);
27+
expect<any>(await configPage.settingsMenuLink.isPresent()).toBe(true);
2828
await configPage.get();
2929
expect<any>(await configPage.applyButton.isDisplayed()).toBe(true);
3030
expect<any>(await configPage.applyButton.isEnabled()).toBe(false);

0 commit comments

Comments
 (0)