Code review updates

Author: pmachapman

src/SIL.XForge.Scripture/ClientApp/src/app/core/permissions.service.ts

@@ -65,10 +65,9 @@ export class PermissionsService {
    * @param project The project.
    * @returns A boolean value.
    */
-  canAccessText(textDocId?: TextDocId, project?: SFProjectProfile): boolean {
+  canAccessText(textDocId: TextDocId, project?: SFProjectProfile): boolean {
     // Ensure the user has project level permission to view the text
     if (
-      textDocId != null &&
       project != null &&
       SF_PROJECT_RIGHTS.hasRight(project, this.userService.currentUserId, SFProjectDomain.Texts, Operation.View)
     ) {

src/SIL.XForge.Scripture/ClientApp/src/app/core/text-doc.service.spec.ts

@@ -410,13 +410,13 @@ describe('TextDocService', () => {
       expect(actual).toBeUndefined();
     });
 
-    it('should return undefined if the user does not have the permission', () => {
+    it('should return false if the user does not have the permission', () => {
       const env = new TestEnvironment();
       const text: Partial<TextInfo> = { chapters: [{ number: 1 } as Chapter] };
 
       // SUT
       const actual: boolean | undefined = env.textDocService.hasChapterEditPermissionForText(text as TextInfo, 1);
-      expect(actual).toBeUndefined();
+      expect(actual).toBe(false);
     });
 
     it('should return false if the user does not have the write permission for the chapter', () => {

src/SIL.XForge.Scripture/ClientApp/src/app/core/text-doc.service.ts

@@ -187,11 +187,12 @@ export class TextDocService {
    */
   hasChapterEditPermissionForText(text: TextInfo | undefined, chapterNum: number | undefined): boolean | undefined {
     const chapter: Chapter | undefined = text?.chapters.find(c => c.number === chapterNum);
+    if (chapter == null) return undefined;
     // Even though permissions is guaranteed to be there in the model, its not in IndexedDB the first time the project
     // is accessed after migration
     const permission: string | undefined =
       chapter?.permissions?.[this.userService.currentUserId] ?? text?.permissions?.[this.userService.currentUserId];
-    return permission == null ? undefined : permission === TextInfoPermission.Write;
+    return permission === TextInfoPermission.Write;
   }
 
   /**

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.ts

@@ -528,11 +528,12 @@ export class EditorComponent extends DataLoadingComponent implements OnDestroy,
 
   get hasSourceViewRight(): boolean {
     const sourceProject = this.sourceProjectDoc?.data;
-    if (sourceProject == null) {
+    const sourceId = this.source?.id;
+    if (sourceProject == null || sourceId == null) {
       return this.isParatextUserRole;
     }
 
-    return this.isParatextUserRole && this.permissionsService.canAccessText(this.source?.id, sourceProject);
+    return this.isParatextUserRole && this.permissionsService.canAccessText(sourceId, sourceProject);
   }
 
   get canInsertNote(): boolean {