Skip to content

Commit 1202640

Browse files
SF-3617 Detect books without content and exclude from drafting option (#3660)
1 parent eda080f commit 1202640

File tree

4 files changed

+221
-162
lines changed

4 files changed

+221
-162
lines changed

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.html

Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ <h2>{{ t("translated_books") }}</h2>
134134
(bookSelect)="onTranslatedBookSelect($event)"
135135
data-test-id="draft-stepper-training-books"
136136
></app-book-multi-select>
137-
@if (unusableTrainingSourceBooks.length) {
137+
@if (unusableTrainingSourceBooks.length > 0 || trainingBooksWithoutEnoughData.length > 0) {
138138
<app-notice icon="info" mode="basic" type="light" class="unusable-training-books">
139139
<div class="notice-container">
140140
<span
@@ -143,22 +143,33 @@ <h2>{{ t("translated_books") }}</h2>
143143
[innerHtml]="
144144
!expandUnusableTrainingBooks
145145
? i18n.translateAndInsertTags('draft_generation_steps.books_are_hidden_show_why', {
146-
numBooks: unusableTrainingSourceBooks.length
146+
numBooks: unusableTrainingSourceBooks.length + trainingBooksWithoutEnoughData.length
147147
})
148148
: i18n.translateAndInsertTags('draft_generation_steps.books_are_hidden_hide_explanation', {
149-
numBooks: unusableTrainingSourceBooks.length
149+
numBooks: unusableTrainingSourceBooks.length + trainingBooksWithoutEnoughData.length
150150
})
151151
"
152152
>
153153
</span>
154154
@if (expandUnusableTrainingBooks) {
155-
<h4 class="explanation">
156-
<transloco
157-
key="draft_generation_steps.these_source_books_cannot_be_used_for_training"
158-
[params]="{ firstTrainingSource }"
159-
></transloco>
160-
</h4>
161-
<span class="book-names">{{ bookNames(unusableTrainingSourceBooks) }}</span>
155+
@if (trainingBooksWithoutEnoughData.length > 0) {
156+
<h4 class="explanation">
157+
<transloco
158+
key="draft_generation_steps.these_training_source_books_are_blank"
159+
[params]="{ firstTrainingSource }"
160+
></transloco>
161+
</h4>
162+
<span class="book-names">{{ bookNames(trainingBooksWithoutEnoughData) }}</span>
163+
}
164+
@if (unusableTrainingSourceBooks.length > 0) {
165+
<h4 class="explanation">
166+
<transloco
167+
key="draft_generation_steps.these_source_books_cannot_be_used_for_training"
168+
[params]="{ firstTrainingSource }"
169+
></transloco>
170+
</h4>
171+
<span class="book-names">{{ bookNames(unusableTrainingSourceBooks) }}</span>
172+
}
162173
}
163174
</div>
164175
</app-notice>

0 commit comments

Comments
 (0)