Enable promise linting in RealtimeServer (#3414)

Co-authored-by: marksvc <marksvc@gmail.com>

Author: Nateowami

src/RealtimeServer/.eslintrc.json

@@ -35,6 +35,8 @@
         ],
         "@typescript-eslint/naming-convention": ["error", { "selector": "enumMember", "format": ["PascalCase"] }],
         "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/no-floating-promises": "error",
+        "@typescript-eslint/no-misused-promises": "error",
         "@typescript-eslint/no-non-null-assertion": "off",
         "@typescript-eslint/no-unused-vars": [
           "error",
@@ -63,6 +65,10 @@
         ],
         "no-underscore-dangle": "off"
       }
+    },
+    {
+      "files": ["*.spec.ts"],
+      "rules": { "@typescript-eslint/no-floating-promises": "off", "@typescript-eslint/no-misused-promises": "off" }
     }
   ]
 }

src/RealtimeServer/scriptureforge/migrator.ts

@@ -68,4 +68,4 @@ async function runMigrations() {
   }
 }
 
-runMigrations();
+void runMigrations();

src/RealtimeServer/scriptureforge/services/note-thread-service.ts

@@ -222,19 +222,22 @@ export class NoteThreadService extends SFProjectDataService<NoteThread> {
     return applicableDomains;
   }
 
-  protected onDelete(userId: string, docId: string, projectDomain: string, entity: OwnedData): Promise<void> {
+  protected async onDelete(userId: string, docId: string, projectDomain: string, entity: OwnedData): Promise<void> {
     if (projectDomain === SFProjectDomain.Notes) {
-      this.removeEntityHaveReadRefs(userId, docId, projectDomain, entity);
+      await this.removeEntityHaveReadRefs(userId, docId, projectDomain, entity);
     }
-    return Promise.resolve();
   }
 
-  protected onBeforeDelete(userId: string, docId: string, projectDomain: string, entity: OwnedData): Promise<void> {
+  protected async onBeforeDelete(
+    userId: string,
+    docId: string,
+    projectDomain: string,
+    entity: OwnedData
+  ): Promise<void> {
     // Process an incoming deletion for a NoteThread before it happens so we can look at its list of notes.
     if (projectDomain === SFProjectDomain.PTNoteThreads) {
-      this.removeEntityHaveReadRefs(userId, docId, projectDomain, entity);
+      await this.removeEntityHaveReadRefs(userId, docId, projectDomain, entity);
     }
-    return Promise.resolve();
   }
 
   private async removeEntityHaveReadRefs(

src/RealtimeServer/scriptureforge/services/question-service.ts

@@ -238,11 +238,15 @@ export class QuestionService extends SFProjectDataService<Question> {
     ];
   }
 
-  protected onDelete(userId: string, docId: string, projectDomain: SFProjectDomain, entity: OwnedData): Promise<void> {
+  protected async onDelete(
+    userId: string,
+    docId: string,
+    projectDomain: SFProjectDomain,
+    entity: OwnedData
+  ): Promise<void> {
     if (projectDomain === SFProjectDomain.Answers || projectDomain === SFProjectDomain.AnswerComments) {
-      this.removeEntityReadRefs(userId, docId, projectDomain, entity);
+      await this.removeEntityReadRefs(userId, docId, projectDomain, entity);
     }
-    return Promise.resolve();
   }
 
   private async removeEntityReadRefs(