Fix how Node options are specified for build step and production

Author: Nateowami

.github/workflows/release-live.yml

@@ -125,6 +125,5 @@ jobs:
       app_suffix: ""
       version_number: "${{ needs.determine_version.outputs.next_version }}"
       vcs_tag_prefix: "SFv"
-      node_options: "--optimize_for_size --max_old_space_size=4096"
       project: "SIL.XForge.Scripture"
       server_domain_name: "scriptureforge.org"

.github/workflows/release-qa.yml

@@ -146,6 +146,5 @@ jobs:
       app_suffix: "_qa"
       version_number: "${{ needs.determine_version.outputs.next_version }}"
       vcs_tag_prefix: "SF-QAv"
-      node_options: "--optimize_for_size --max_old_space_size=4096"
       project: "SIL.XForge.Scripture"
       server_domain_name: "qa.scriptureforge.org"

.github/workflows/release.yml

@@ -52,10 +52,6 @@ on:
         description: "The version number to use for the deployment."
         type: string
         required: true
-      node_options:
-        description: "Node-related options when building RealtimeServer."
-        type: string
-        required: true
       project:
         description: "The project to deploy."
         type: string
@@ -174,7 +170,6 @@ jobs:
           DEPLOY_CREDENTIALS: ~/.ssh/deploy_key
           HOSTNAME: ${{inputs.server_domain_name}}
           ALTERNATE_DOMAIN: ${{secrets.alternate_domain}}
-          NODE_OPTIONS: ${{inputs.node_options}}
           PARATEXT_CLIENT_ID: ${{secrets.paratext_client_id}}
           PROJECT: ${{inputs.project}}
           SERVAL_CLIENT_ID: ${{secrets.serval_client_id}}

scripts/build-and-ship

@@ -36,8 +36,7 @@ cat <<EOF >"$BUILD_OUTPUT/app/secrets.json"
   },
   "Site": {
     "Origin": "https://${HOSTNAME};${ALTERNATE_DOMAIN}"
-  },
-  "node-options": "${NODE_OPTIONS}"
+  }
 }
 EOF
 

src/SIL.XForge.Scripture/Startup.cs

@@ -155,7 +155,7 @@ public IServiceProvider ConfigureServices(IServiceCollection services)
 
         services.AddSignalR();
 
-        string? nodeOptions = Configuration.GetValue<string>("node-options");
+        string? nodeOptions = Configuration.GetValue<string>("Realtime:NodeOptions");
         services.AddSFRealtimeServer(LoggerFactory, Configuration, nodeOptions);
 
         services.AddSFServices();

src/SIL.XForge.Scripture/appsettings.json

@@ -29,7 +29,8 @@
     "Prefix": "sf"
   },
   "Realtime": {
-    "Port": 5003
+    "Port": 5003,
+    "NodeOptions": "--optimize_for_size"
   },
   "Bugsnag": {
     "ApiKey": "b72a46a8924a3cd161d4c5534287923c",