SF-3615 Fix error on draft generation page if your cannot access source

Author: RaymondLuong3

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-history-list/draft-history-entry/draft-history-entry.component.spec.ts

@@ -6,7 +6,7 @@ import { SFProjectProfile } from 'realtime-server/lib/esm/scriptureforge/models/
 import { createTestProjectProfile } from 'realtime-server/lib/esm/scriptureforge/models/sf-project-test-data';
 import { ParagraphBreakFormat, QuoteFormat } from 'realtime-server/lib/esm/scriptureforge/models/translate-config';
 import { of } from 'rxjs';
-import { anything, instance, mock, when } from 'ts-mockito';
+import { anything, instance, mock, verify, when } from 'ts-mockito';
 import { ActivatedProjectService } from 'xforge-common/activated-project.service';
 import { createTestFeatureFlag, FeatureFlagService } from 'xforge-common/feature-flags/feature-flag.service';
 import { I18nService } from 'xforge-common/i18n.service';
@@ -18,6 +18,7 @@ import { UserService } from 'xforge-common/user.service';
 import { SFProjectProfileDoc } from '../../../../core/models/sf-project-profile-doc';
 import { SF_TYPE_REGISTRY } from '../../../../core/models/sf-type-registry';
 import { TrainingDataDoc } from '../../../../core/models/training-data-doc';
+import { PermissionsService } from '../../../../core/permissions.service';
 import { SFProjectService } from '../../../../core/sf-project.service';
 import { BuildDto } from '../../../../machine-api/build-dto';
 import { BuildStates } from '../../../../machine-api/build-states';
@@ -34,6 +35,7 @@ const mockedTrainingDataService = mock(TrainingDataService);
 const mockedActivatedProjectService = mock(ActivatedProjectService);
 const mockedFeatureFlagsService = mock(FeatureFlagService);
 const mockedDraftOptionsService = mock(DraftOptionsService);
+const mockedPermissionsService = mock(PermissionsService);
 
 const oneDay = 1000 * 60 * 60 * 24;
 const dateBeforeFormattingSupported = new Date(FORMATTING_OPTIONS_SUPPORTED_DATE.getTime() - oneDay).toISOString();
@@ -58,7 +60,8 @@ describe('DraftHistoryEntryComponent', () => {
       { provide: TrainingDataService, useMock: mockedTrainingDataService },
       { provide: ActivatedProjectService, useMock: mockedActivatedProjectService },
       { provide: FeatureFlagService, useMock: mockedFeatureFlagsService },
-      { provide: DraftOptionsService, useMock: mockedDraftOptionsService }
+      { provide: DraftOptionsService, useMock: mockedDraftOptionsService },
+      { provide: PermissionsService, useMock: mockedPermissionsService }
     ]
   }));
 
@@ -84,6 +87,7 @@ describe('DraftHistoryEntryComponent', () => {
       instance(trainingDataQuery)
     );
     when(mockedDraftOptionsService.areFormattingOptionsAvailableButUnselected(anything())).thenReturn(true);
+    when(mockedPermissionsService.isUserOnProject(anything())).thenResolve(true);
     fixture = TestBed.createComponent(DraftHistoryEntryComponent);
     component = fixture.componentInstance;
     fixture.detectChanges();
@@ -149,6 +153,25 @@ describe('DraftHistoryEntryComponent', () => {
       expect(fixture.nativeElement.querySelector('.requested-label')).not.toBeNull();
     }));
 
+    it('should not get source project if user does not have permission', fakeAsync(() => {
+      when(mockedPermissionsService.isUserOnProject(anything())).thenResolve(false);
+      const user = 'user-display-name';
+      const date = dateAfterFormattingSupported;
+      const trainingBooks = ['GEN'];
+      const translateBooks = ['EXO'];
+      const trainingDataFiles = [];
+      const entry = getStandardBuildDto({ user, date, trainingBooks, translateBooks, trainingDataFiles });
+
+      // SUT
+      component.entry = entry;
+      tick();
+      fixture.detectChanges();
+
+      verify(mockedPermissionsService.isUserOnProject('project02')).twice();
+      verify(mockedSFProjectService.getProfile('project02')).never();
+      expect(component.translationSource).toEqual('');
+    }));
+
     it('should state that the model did not have training configuration', fakeAsync(() => {
       when(mockedI18nService.enumerateList(anything())).thenReturn('src');
       const user = 'user-display-name';

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-history-list/draft-history-entry/draft-history-entry.component.ts

@@ -13,6 +13,7 @@ import { RealtimeQuery } from 'xforge-common/models/realtime-query';
 import { UserService } from 'xforge-common/user.service';
 import { SFProjectProfileDoc } from '../../../../core/models/sf-project-profile-doc';
 import { TrainingDataDoc } from '../../../../core/models/training-data-doc';
+import { PermissionsService } from '../../../../core/permissions.service';
 import { SFProjectService } from '../../../../core/sf-project.service';
 import { BuildDto } from '../../../../machine-api/build-dto';
 import { BuildStates } from '../../../../machine-api/build-states';
@@ -97,8 +98,11 @@ export class DraftHistoryEntryComponent {
         // Get the target language, if it is not already set
         this._targetLanguage ??= target?.data?.writingSystem.tag;
 
-        // Get the source project, if it is configured
-        const source = r.projectId === '' ? undefined : await this.projectService.getProfile(r.projectId);
+        let source: SFProjectProfileDoc | undefined;
+        // Get the source project, if it is configured and the user has access
+        if (await this.permissionsService.isUserOnProject(r.projectId)) {
+          source = r.projectId === '' ? undefined : await this.projectService.getProfile(r.projectId);
+        }
 
         // Get the source language, if it is not already set
         this._sourceLanguage ??= source?.data?.writingSystem.tag;
@@ -126,10 +130,13 @@ export class DraftHistoryEntryComponent {
     this._translationSources = [];
     void Promise.all(
       translationScriptureRanges.map(async r => {
-        const source =
-          r.projectId === '' || r.projectId === value?.engine?.id
-            ? undefined
-            : await this.projectService.getProfile(r.projectId);
+        let source: SFProjectProfileDoc | undefined;
+        if (await this.permissionsService.isUserOnProject(r.projectId)) {
+          source =
+            r.projectId === '' || r.projectId === value?.engine?.id
+              ? undefined
+              : await this.projectService.getProfile(r.projectId);
+        }
         const sourceShortName = source?.data?.shortName;
         if (sourceShortName != null) this._translationSources.push(sourceShortName);
       })
@@ -294,6 +301,7 @@ export class DraftHistoryEntryComponent {
     private readonly activatedProjectService: ActivatedProjectService,
     readonly featureFlags: FeatureFlagService,
     private readonly draftOptionsService: DraftOptionsService,
+    private readonly permissionsService: PermissionsService,
     private readonly destroyRef: DestroyRef
   ) {}