Minor fixes to onboarding management (#3695)

Author: Nateowami

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/draft-request-detail.component.ts

@@ -34,7 +34,7 @@ import {
   DraftRequestResolutionMetadata,
   OnboardingRequest,
   OnboardingRequestService
-} from '../translate/draft-generation/drafting-signup.service';
+} from '../translate/draft-generation/onboarding-request.service';
 import { ServalAdministrationService } from './serval-administration.service';
 
 /**
@@ -220,7 +220,7 @@ export class DraftRequestDetailComponent extends DataLoadingComponent implements
   }
 
   get isResolved(): boolean {
-    return this.request?.resolution !== 'unresolved';
+    return this.request?.resolution != null && this.request.resolution !== 'unresolved';
   }
 
   getStatus = this.onboardingRequestService.getStatus;
@@ -304,7 +304,7 @@ export class DraftRequestDetailComponent extends DataLoadingComponent implements
     if (zipFileNames.length === 0) {
       return '';
     }
-    return `python -m silnlp.common.onboard_project --copy-from --clean-project --extract-corpora --collect-verse-counts --wildebeest --timestamp ${zipFileNames.join(' ')}`;
+    return `python -m silnlp.common.onboard_project --copy-from --clean-project --extract-corpora --collect-verse-counts --wildebeest --datestamp ${zipFileNames.join(' ')}`;
   }
 
   /** Adds a comment to the current draft request. */

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/onboarding-requests/onboarding-requests.component.ts

@@ -21,7 +21,7 @@ import {
   DraftRequestResolutionKey,
   OnboardingRequest,
   OnboardingRequestService
-} from '../../translate/draft-generation/drafting-signup.service';
+} from '../../translate/draft-generation/onboarding-request.service';
 import { ServalAdministrationService } from '../serval-administration.service';
 
 type RequestFilterFunction = (request: OnboardingRequest, currentUserId: string | undefined) => boolean;

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation.component.ts

@@ -62,7 +62,7 @@ import { DraftPreviewBooksComponent } from './draft-preview-books/draft-preview-
 import { DRAFT_SIGNUP_RESPONSE_DAYS } from './draft-signup-form/draft-onboarding-form.component';
 import { DraftSource } from './draft-source';
 import { DraftSourcesService } from './draft-sources.service';
-import { OnboardingRequest, OnboardingRequestService } from './drafting-signup.service';
+import { OnboardingRequest, OnboardingRequestService } from './onboarding-request.service';
 import { PreTranslationSignupUrlService } from './pretranslation-signup-url.service';
 import { SupportedBackTranslationLanguagesDialogComponent } from './supported-back-translation-languages-dialog/supported-back-translation-languages-dialog.component';
 

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-signup-form/draft-onboarding-form.component.ts

@@ -28,7 +28,7 @@ import { ProjectSelectComponent } from '../../../project-select/project-select.c
 import { BookMultiSelectComponent } from '../../../shared/book-multi-select/book-multi-select.component';
 import { JsonViewerComponent } from '../../../shared/json-viewer/json-viewer.component';
 import { compareProjectsForSorting, projectLabel } from '../../../shared/utils';
-import { DraftingSignupFormData, OnboardingRequestService } from '../drafting-signup.service';
+import { DraftingSignupFormData, OnboardingRequestService } from '../onboarding-request.service';
 
 export const DRAFT_SIGNUP_RESPONSE_DAYS = { min: 1, max: 3 } as const;
 

…ft-generation/drafting-signup.service.ts …generation/onboarding-request.service.tssrc/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/drafting-signup.service.ts renamed to src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/onboarding-request.service.ts src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/drafting-signup.service.ts renamed to src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/onboarding-request.service.ts

@@ -349,7 +349,6 @@ public async Task<IRpcMethodResult> SetAssignee(string requestId, string assigne
     /// <summary>
     /// Sets the resolution for a drafting signup request.
     /// Only accessible to Serval admins.
-    /// If resolution is set to a non-null value, the assignee is cleared.
     /// Status is automatically calculated based on assignee and resolution.
     /// </summary>
     public async Task<IRpcMethodResult> SetResolution(string requestId, string? resolution)