Clearing filter for "Go to questions"

This was necessary for cases where a filter present was hiding the first question, after the button was clicked. I believe it's exceedingly rare that we'd want to preserve their filter when they click this button.

Author: josephmyers

src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking-questions/checking-questions.component.ts

@@ -43,6 +43,7 @@ export interface QuestionChangeActionSource {
 export interface QuestionChangedEvent {
   questionDoc: QuestionDoc | undefined;
   actionSource: QuestionChangeActionSource | undefined;
+  clearFilter?: boolean;
 }
 
 // For performance reasons, this component uses the OnPush change detection strategy rather than the default change
@@ -216,7 +217,7 @@ export class CheckingQuestionsComponent implements OnInit, OnChanges {
 
   protected activateFirstUnansweredQuestion(): void {
     if (!this.hasUnansweredQuestion || this._firstUnansweredQuestion == null) return;
-    this.activateQuestion(this._firstUnansweredQuestion.docs[0], { isQuestionListChange: false });
+    this.activateQuestion(this._firstUnansweredQuestion.docs[0], { isQuestionListChange: false }, true);
   }
 
   private get canAddAnswer(): boolean {
@@ -381,7 +382,7 @@ export class CheckingQuestionsComponent implements OnInit, OnChanges {
     this.changeQuestion(-1);
   }
 
-  activateQuestion(questionDoc: QuestionDoc, actionSource?: QuestionChangeActionSource): void {
+  activateQuestion(questionDoc: QuestionDoc, actionSource?: QuestionChangeActionSource, clearFilter?: boolean): void {
     const verseRef: VerseRefData | undefined = questionDoc.data?.verseRef;
 
     // The reason for the convoluted questionChanged logic is because the change needs to be emitted even if it's the
@@ -397,7 +398,7 @@ export class CheckingQuestionsComponent implements OnInit, OnChanges {
       this.storeMostRecentQuestion().then(() => {
         // Only emit if not a filter to avoid duplicate emission, as an emit from filter is called elsewhere
         if (!actionSource?.isQuestionListChange) {
-          this.changed.emit({ questionDoc, actionSource });
+          this.changed.emit({ questionDoc, actionSource, clearFilter });
         }
 
         if (questionChanged) {

src/SIL.XForge.Scripture/ClientApp/src/app/checking/checking/checking.component.ts

@@ -912,7 +912,7 @@ export class CheckingComponent extends DataLoadingComponent implements OnInit, A
   }
 
   // if click question in question list
-  questionChanged({ questionDoc, actionSource }: QuestionChangedEvent): void {
+  questionChanged({ questionDoc, actionSource, clearFilter }: QuestionChangedEvent): void {
     if (this.questionsList == null) {
       return;
     }
@@ -922,6 +922,10 @@ export class CheckingComponent extends DataLoadingComponent implements OnInit, A
       this.setQuestionsOverlayVisibility(false);
     }
 
+    if (clearFilter) {
+      this.resetFilter();
+    }
+
     if (questionDoc != null) {
       this.updateActiveQuestionVerseRef(questionDoc);
       this.updateAdjacentQuestions(questionDoc);