Fix non-thread safe crash in Paratext Settings when viewing history (#3605)

pmachapman · web-flow · commit c4a8e758d197 · 2025-12-10T11:45:28.000+13:00
diff --git a/src/SIL.XForge.Scripture/Services/ParatextService.cs b/src/SIL.XForge.Scripture/Services/ParatextService.cs
@@ -2254,6 +2254,10 @@ int chapter
         {
             string ptProjectId = projectDoc.Data.ParatextId;
             scrText = GetScrText(userSecret, ptProjectId);
+
+            // The ScrText Settings maintains a non-thread safe dictionary cache of book filenames to book numbers.
+            // We initialize it here to prevent issues when iterating over revisions below.
+            _ = scrText.Settings.GetBookNumberFromFilename(string.Empty);
         }
         catch (DataNotFoundException)
         {

Original file line number	Diff line number	Diff line change
`@@ -2254,6 +2254,10 @@ int chapter`
`2254`	`2254`	`{`
`2255`	`2255`	`string ptProjectId = projectDoc.Data.ParatextId;`
`2256`	`2256`	`scrText = GetScrText(userSecret, ptProjectId);`
	`2257`	`+`
	`2258`	`+ // The ScrText Settings maintains a non-thread safe dictionary cache of book filenames to book numbers.`
	`2259`	`+ // We initialize it here to prevent issues when iterating over revisions below.`
	`2260`	`+ _ = scrText.Settings.GetBookNumberFromFilename(string.Empty);`
`2257`	`2261`	`}`
`2258`	`2262`	`catch (DataNotFoundException)`
`2259`	`2263`	`{`