Skip to content

Commit d720910

Browse files
authored
SF-3632 Specify style marker and embed marker behavior as strip (#3559)
1 parent 7390b24 commit d720910

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

src/SIL.XForge.Scripture/Services/PreTranslationService.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,8 @@ CancellationToken cancellationToken
207207
QuoteStyleOptions.Normalized => PretranslationNormalizationBehavior.Normalized,
208208
_ => PretranslationNormalizationBehavior.Denormalized,
209209
},
210+
embedBehavior: PretranslationUsfmMarkerBehavior.Strip,
211+
styleMarkerBehavior: PretranslationUsfmMarkerBehavior.Strip,
210212
cancellationToken: cancellationToken
211213
);
212214

test/SIL.XForge.Scripture.Tests/Services/PreTranslationServiceTests.cs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -485,6 +485,8 @@ await env
485485
Arg.Any<PretranslationUsfmTemplate>(),
486486
paragraphMarkerBehavior: PretranslationUsfmMarkerBehavior.Strip,
487487
quoteNormalizationBehavior: PretranslationNormalizationBehavior.Denormalized,
488+
embedBehavior: PretranslationUsfmMarkerBehavior.Strip,
489+
styleMarkerBehavior: PretranslationUsfmMarkerBehavior.Strip,
488490
cancellationToken: CancellationToken.None
489491
);
490492

@@ -506,6 +508,8 @@ await env
506508
Arg.Any<PretranslationUsfmTemplate>(),
507509
paragraphMarkerBehavior: PretranslationUsfmMarkerBehavior.PreservePosition,
508510
quoteNormalizationBehavior: PretranslationNormalizationBehavior.Denormalized,
511+
embedBehavior: PretranslationUsfmMarkerBehavior.Strip,
512+
styleMarkerBehavior: PretranslationUsfmMarkerBehavior.Strip,
509513
cancellationToken: CancellationToken.None
510514
);
511515

@@ -527,6 +531,8 @@ await env
527531
Arg.Any<PretranslationUsfmTemplate>(),
528532
paragraphMarkerBehavior: PretranslationUsfmMarkerBehavior.Preserve,
529533
quoteNormalizationBehavior: PretranslationNormalizationBehavior.Denormalized,
534+
embedBehavior: PretranslationUsfmMarkerBehavior.Strip,
535+
styleMarkerBehavior: PretranslationUsfmMarkerBehavior.Strip,
530536
cancellationToken: CancellationToken.None
531537
);
532538
}
@@ -557,6 +563,8 @@ await env
557563
Arg.Any<PretranslationUsfmTemplate>(),
558564
paragraphMarkerBehavior: PretranslationUsfmMarkerBehavior.PreservePosition,
559565
quoteNormalizationBehavior: PretranslationNormalizationBehavior.Normalized,
566+
embedBehavior: PretranslationUsfmMarkerBehavior.Strip,
567+
styleMarkerBehavior: PretranslationUsfmMarkerBehavior.Strip,
560568
cancellationToken: CancellationToken.None
561569
);
562570

@@ -578,6 +586,8 @@ await env
578586
Arg.Any<PretranslationUsfmTemplate>(),
579587
paragraphMarkerBehavior: PretranslationUsfmMarkerBehavior.PreservePosition,
580588
quoteNormalizationBehavior: PretranslationNormalizationBehavior.Denormalized,
589+
embedBehavior: PretranslationUsfmMarkerBehavior.Strip,
590+
styleMarkerBehavior: PretranslationUsfmMarkerBehavior.Strip,
581591
cancellationToken: CancellationToken.None
582592
);
583593
}
@@ -804,6 +814,8 @@ public TestEnvironment(TestEnvironmentOptions? options = null)
804814
template: PretranslationUsfmTemplate.Source,
805815
paragraphMarkerBehavior: Arg.Any<PretranslationUsfmMarkerBehavior>(),
806816
quoteNormalizationBehavior: Arg.Any<PretranslationNormalizationBehavior>(),
817+
embedBehavior: PretranslationUsfmMarkerBehavior.Strip,
818+
styleMarkerBehavior: PretranslationUsfmMarkerBehavior.Strip,
807819
cancellationToken: CancellationToken.None
808820
)
809821
.Returns(MatthewBookUsfm);

0 commit comments

Comments
 (0)