diff --git a/.github/workflows/release-live.yml b/.github/workflows/release-live.yml index 92088434128..d168f1ea02c 100644 --- a/.github/workflows/release-live.yml +++ b/.github/workflows/release-live.yml @@ -125,6 +125,5 @@ jobs: app_suffix: "" version_number: "${{ needs.determine_version.outputs.next_version }}" vcs_tag_prefix: "SFv" - node_options: "--optimize_for_size --max_old_space_size=4096" project: "SIL.XForge.Scripture" server_domain_name: "scriptureforge.org" diff --git a/.github/workflows/release-qa.yml b/.github/workflows/release-qa.yml index eead82ea0f5..f86e641662f 100644 --- a/.github/workflows/release-qa.yml +++ b/.github/workflows/release-qa.yml @@ -146,6 +146,5 @@ jobs: app_suffix: "_qa" version_number: "${{ needs.determine_version.outputs.next_version }}" vcs_tag_prefix: "SF-QAv" - node_options: "--optimize_for_size --max_old_space_size=4096" project: "SIL.XForge.Scripture" server_domain_name: "qa.scriptureforge.org" diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index eab63749261..57b91e8fd31 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -52,10 +52,6 @@ on: description: "The version number to use for the deployment." type: string required: true - node_options: - description: "Node-related options when building RealtimeServer." - type: string - required: true project: description: "The project to deploy." type: string @@ -174,7 +170,6 @@ jobs: DEPLOY_CREDENTIALS: ~/.ssh/deploy_key HOSTNAME: ${{inputs.server_domain_name}} ALTERNATE_DOMAIN: ${{secrets.alternate_domain}} - NODE_OPTIONS: ${{inputs.node_options}} PARATEXT_CLIENT_ID: ${{secrets.paratext_client_id}} PROJECT: ${{inputs.project}} SERVAL_CLIENT_ID: ${{secrets.serval_client_id}} diff --git a/scripts/build-and-ship b/scripts/build-and-ship index f19c2acfee9..ac2a2e9c275 100755 --- a/scripts/build-and-ship +++ b/scripts/build-and-ship @@ -36,8 +36,7 @@ cat <"$BUILD_OUTPUT/app/secrets.json" }, "Site": { "Origin": "https://${HOSTNAME};${ALTERNATE_DOMAIN}" - }, - "node-options": "${NODE_OPTIONS}" + } } EOF diff --git a/src/SIL.XForge.Scripture/Startup.cs b/src/SIL.XForge.Scripture/Startup.cs index 816b9a9f0b9..5dcd4326567 100644 --- a/src/SIL.XForge.Scripture/Startup.cs +++ b/src/SIL.XForge.Scripture/Startup.cs @@ -155,7 +155,7 @@ public IServiceProvider ConfigureServices(IServiceCollection services) services.AddSignalR(); - string? nodeOptions = Configuration.GetValue("node-options"); + string? nodeOptions = Configuration.GetValue("Realtime:NodeOptions"); services.AddSFRealtimeServer(LoggerFactory, Configuration, nodeOptions); services.AddSFServices(); diff --git a/src/SIL.XForge.Scripture/appsettings.json b/src/SIL.XForge.Scripture/appsettings.json index 90895bf3718..10b5e5093e9 100644 --- a/src/SIL.XForge.Scripture/appsettings.json +++ b/src/SIL.XForge.Scripture/appsettings.json @@ -29,7 +29,8 @@ "Prefix": "sf" }, "Realtime": { - "Port": 5003 + "Port": 5003, + "NodeOptions": "--optimize_for_size" }, "Bugsnag": { "ApiKey": "b72a46a8924a3cd161d4c5534287923c",