Skip to content

Commit cc3aece

Browse files
committed
Don't include sourcemap in production build
1 parent 1aacfe0 commit cc3aece

File tree

5 files changed

+11
-7
lines changed

5 files changed

+11
-7
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ name: Test
22

33
on:
44
push:
5-
branches: [ "main" ]
5+
branches: ["main"]
66
pull_request:
7-
branches: [ "main" ]
7+
branches: ["main"]
88

99
permissions:
1010
contents: read

build_bundle.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { updateVersionFile } from "./cmd/update_version.ts";
55

66
await updateVersionFile();
77
await Deno.mkdir("dist", { recursive: true });
8-
await esbuild.build({
8+
const result = await esbuild.build({
99
entryPoints: {
1010
silverbullet: "silverbullet.ts",
1111
"plug-compile": "plug-compile.ts",
@@ -14,8 +14,8 @@ await esbuild.build({
1414
format: "esm",
1515
absWorkingDir: Deno.cwd(),
1616
bundle: true,
17+
//metafile: true,
1718
treeShaking: true,
18-
sourcemap: false,
1919
logLevel: "error",
2020
minify: true,
2121
external: [],
@@ -24,6 +24,10 @@ await esbuild.build({
2424
nodeModulesDir: "auto",
2525
}),
2626
});
27+
if (result.metafile) {
28+
const text = await esbuild.analyzeMetafile(result.metafile!);
29+
console.log("Bundle info", text);
30+
}
2731
const plugBundleJS = await Deno.readTextFile("dist/plug-compile.js");
2832
// Patch output JS with import.meta.main override to avoid ESBuild CLI handling
2933
await Deno.writeTextFile(

build_web.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ async function buildCopyBundleAssets() {
111111
absWorkingDir: Deno.cwd(),
112112
bundle: true,
113113
treeShaking: true,
114-
sourcemap: "linked",
114+
sourcemap: Deno.args[0] === "--production" ? undefined : "linked",
115115
minify: true,
116116
jsxFactory: "h",
117117
// metafile: true,

cmd/compile.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ setupMessageListener(functionMapping, manifest, self.postMessage);
108108
format: "esm",
109109
globalName: "mod",
110110
platform: "browser",
111-
sourcemap: options.debug ? "linked" : false,
111+
sourcemap: options.debug ? "linked" : undefined,
112112
minify: !options.debug,
113113
outfile: outFile,
114114
metafile: options.info,

deno.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"fmt": "deno fmt",
3636
"test": "deno test -A",
3737
"bench": "deno bench",
38-
"build": "rm -rf dist dist_client_bundle dist_plug_bundle && deno run -A build_plugs.ts && deno run -A build_web.ts && deno task compile",
38+
"build": "rm -rf dist dist_client_bundle dist_plug_bundle && deno run -A build_plugs.ts && deno run -A build_web.ts --production && deno task compile",
3939
"plugs": "deno run -A build_plugs.ts",
4040
"server": "deno run -A --check silverbullet.ts",
4141
"generate": "./scripts/generate.sh",

0 commit comments

Comments
 (0)