Filter hidden files and folders, as well as files without extensions

from FetchFileList

Add tests for hidden file and extension filtering in FetchFileList

Author: zefhemel

server/disk_space_primitives.go

@@ -105,6 +105,10 @@ func (d *DiskSpacePrimitives) fileInfoToFileMeta(path string, info os.FileInfo)
 }
 
 // FetchFileList implements SpacePrimitives.FetchFileList
+// Returns a list of files in the space, with the following filtering rules:
+// - Hidden files and directories (starting with '.') are excluded at any depth
+// - Files without extensions are excluded
+// - Files matching gitignore patterns are excluded
 func (d *DiskSpacePrimitives) FetchFileList() ([]FileMeta, error) {
 	var allFiles []FileMeta
 
@@ -114,8 +118,16 @@ func (d *DiskSpacePrimitives) FetchFileList() ([]FileMeta, error) {
 			return nil
 		}
 
-		// Skip directories
+		// Skip hidden directories and stop traversal into them
 		if entry.IsDir() {
+			if strings.HasPrefix(entry.Name(), ".") {
+				return filepath.SkipDir
+			}
+			return nil
+		}
+
+		// Skip hidden files
+		if strings.HasPrefix(entry.Name(), ".") {
 			return nil
 		}
 
@@ -126,8 +138,8 @@ func (d *DiskSpacePrimitives) FetchFileList() ([]FileMeta, error) {
 			return nil
 		}
 
-		// Skip hidden folders in root
-		if strings.HasPrefix(relativePath, ".") {
+		// Skip files without extensions
+		if filepath.Ext(relativePath) == "" {
 			return nil
 		}
 

server/disk_space_primitives_test.go

@@ -61,6 +61,95 @@ func TestGitIgnore(t *testing.T) {
 
 }
 
+func TestHiddenFilesAndDirectories(t *testing.T) {
+	space, err := NewDiskSpacePrimitives(t.TempDir(), "")
+	assert.NoError(t, err, "Failed to create DiskSpacePrimitives")
+
+	// Create various files and directories
+	_, err = space.WriteFile("visible.txt", []byte("visible"), nil)
+	assert.NoError(t, err)
+
+	_, err = space.WriteFile(".hidden.txt", []byte("hidden"), nil)
+	assert.NoError(t, err)
+
+	_, err = space.WriteFile("dir/.hidden.txt", []byte("hidden in dir"), nil)
+	assert.NoError(t, err)
+
+	_, err = space.WriteFile("dir/visible.txt", []byte("visible in dir"), nil)
+	assert.NoError(t, err)
+
+	_, err = space.WriteFile(".hidden/visible.txt", []byte("visible in hidden dir"), nil)
+	assert.NoError(t, err)
+
+	// Test deeply nested hidden directory
+	_, err = space.WriteFile(".hidden/.nested/deep.txt", []byte("deep nested hidden"), nil)
+	assert.NoError(t, err)
+
+	_, err = space.WriteFile("visible/.hidden/nested.txt", []byte("hidden in visible dir"), nil)
+	assert.NoError(t, err)
+
+	fileList, err := space.FetchFileList()
+	assert.NoError(t, err)
+
+	// Should only contain visible files (not hidden files or files in hidden directories)
+	assert.Len(t, fileList, 2)
+
+	fileNames := make([]string, len(fileList))
+	for i, file := range fileList {
+		fileNames[i] = file.Name
+	}
+
+	assert.Contains(t, fileNames, "visible.txt")
+	assert.Contains(t, fileNames, "dir/visible.txt")
+	assert.NotContains(t, fileNames, ".hidden.txt")
+	assert.NotContains(t, fileNames, "dir/.hidden.txt")
+	assert.NotContains(t, fileNames, ".hidden/visible.txt")
+	assert.NotContains(t, fileNames, ".hidden/.nested/deep.txt")
+	assert.NotContains(t, fileNames, "visible/.hidden/nested.txt")
+}
+
+func TestFileExtensionRequirement(t *testing.T) {
+	space, err := NewDiskSpacePrimitives(t.TempDir(), "")
+	assert.NoError(t, err, "Failed to create DiskSpacePrimitives")
+
+	// Create files with and without extensions
+	_, err = space.WriteFile("file.txt", []byte("with extension"), nil)
+	assert.NoError(t, err)
+
+	_, err = space.WriteFile("file.md", []byte("with extension"), nil)
+	assert.NoError(t, err)
+
+	_, err = space.WriteFile("noextension", []byte("without extension"), nil)
+	assert.NoError(t, err)
+
+	_, err = space.WriteFile("README", []byte("without extension"), nil)
+	assert.NoError(t, err)
+
+	_, err = space.WriteFile("dir/file.json", []byte("with extension in dir"), nil)
+	assert.NoError(t, err)
+
+	_, err = space.WriteFile("dir/noext", []byte("without extension in dir"), nil)
+	assert.NoError(t, err)
+
+	fileList, err := space.FetchFileList()
+	assert.NoError(t, err)
+
+	// Should only contain files with extensions
+	assert.Len(t, fileList, 3)
+
+	fileNames := make([]string, len(fileList))
+	for i, file := range fileList {
+		fileNames[i] = file.Name
+	}
+
+	assert.Contains(t, fileNames, "file.txt")
+	assert.Contains(t, fileNames, "file.md")
+	assert.Contains(t, fileNames, "dir/file.json")
+	assert.NotContains(t, fileNames, "noextension")
+	assert.NotContains(t, fileNames, "README")
+	assert.NotContains(t, fileNames, "dir/noext")
+}
+
 // Test directory cleanup - specific to disk implementation
 func TestCleanOrphaned(t *testing.T) {
 	tmpDir := t.TempDir()