Add linebreak-style rule

[GuySartorelli]

From silverstripe/silverstripe-admin#1854 (comment):

on windows, it requires this to work
module.exports.rules['linebreak-style'] = ['error', 'windows'];

otherwise you get Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style

could be nice to add that as a default for https://github.com/silverstripe/eslint-config/blob/1/.eslintrc.js to make it windows friendly

Seems like a sensible thing to do so contributions are a little smoother.

[emteknetnz]

This seems like a really, really bad idea so I'm going to close this issue.

I tried adding this, ran yarn lint and immediately got thousands of errors error Expected linebreaks to be 'CRLF' but found 'LF

Basically the rule above (unless I've completely misunderstood this) means "Use windows line-breaks" i.e. CRLF aka \r\n

Currently our rules are "Use linux line breaks" i.e. LF aka \n

The correct solution for windows users would be to set their IDE config to use unix line breaks.

[GuySartorelli]

@lekoala pinging you since it was your idea and you can point out if something was misunderstood.

[lekoala]

@GuySartorelli emteknetnz is right, that config wouldn't work as I thought it would. I'm still not sure why I get these errors because my ide is configured to use linux file endings, so it could be a compilation thing...

so i'm fine with this being closed if I need to work on js files again I'll have a better look at it