Merge pull request #1312 from holyavocad0/patch-1

GuySartorelli · web-flow · commit f5cfc22aba71 · 2024-08-14T11:58:52.000+12:00
FIX Update EditableFormHeading.php to output unique ID attributes to comply with accessibility standards
diff --git a/code/Model/EditableFormField/EditableFormHeading.php b/code/Model/EditableFormField/EditableFormHeading.php
@@ -70,7 +70,7 @@ public function getCMSFields()
 
     public function getFormField()
     {
-        $labelField = HeaderField::create('userforms-header', $this->Title ?: false)
+        $labelField = HeaderField::create('userforms-header-' . $this->ID, $this->Title ?: false)
             ->setHeadingLevel($this->Level);
         $labelField->addExtraClass('FormHeading');
         $labelField->setAttribute('data-id', $this->Name);

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public function getCMSFields()`
`70`	`70`
`71`	`71`	`public function getFormField()`
`72`	`72`	`{`
`73`		`- $labelField = HeaderField::create('userforms-header', $this->Title ?: false)`
	`73`	`+ $labelField = HeaderField::create('userforms-header-' . $this->ID, $this->Title ?: false)`
`74`	`74`	`->setHeadingLevel($this->Level);`
`75`	`75`	`$labelField->addExtraClass('FormHeading');`
`76`	`76`	`$labelField->setAttribute('data-id', $this->Name);`