Fetch int-64 values from h5grove as binary to maintain precision

Author: axelboc

packages/app/src/providers/h5grove/__snapshots__/h5grove-api.test.ts.snap

@@ -174,7 +174,7 @@ exports[`test file matches snapshot 1`] = `
       "signed": true,
       "size": 64,
     },
-    "value": -9223372036854776000,
+    "value": -9223372036854775808n,
   },
   {
     "name": "int64_2D",
@@ -195,14 +195,14 @@ exports[`test file matches snapshot 1`] = `
       "signed": true,
       "size": 64,
     },
-    "value": [
-      0,
-      1,
-      2,
-      3,
-      4,
-      5,
-    ],
+    "value": BigInt64Array {
+      "0": 0n,
+      "1": 1n,
+      "2": 2n,
+      "3": 3n,
+      "4": 4n,
+      "5": 5n,
+    },
   },
   {
     "name": "uint8_scalar",
@@ -358,7 +358,7 @@ exports[`test file matches snapshot 1`] = `
       "signed": false,
       "size": 64,
     },
-    "value": 18446744073709552000,
+    "value": 18446744073709551615n,
   },
   {
     "name": "uint64_3D",
@@ -380,16 +380,16 @@ exports[`test file matches snapshot 1`] = `
       "signed": false,
       "size": 64,
     },
-    "value": [
-      0,
-      1,
-      2,
-      3,
-      4,
-      5,
-      6,
-      18446744073709552000,
-    ],
+    "value": BigUint64Array {
+      "0": 0n,
+      "1": 1n,
+      "2": 2n,
+      "3": 3n,
+      "4": 4n,
+      "5": 5n,
+      "6": 6n,
+      "7": 18446744073709551615n,
+    },
   },
   {
     "name": "float16_scalar",

packages/app/src/providers/h5grove/utils.ts

@@ -23,9 +23,12 @@ import {
   timeType,
   unknownType,
 } from '@h5web/shared/hdf5-utils';
-import { type TypedArrayConstructor } from '@h5web/shared/vis-models';
+import {
+  type BigIntTypedArrayConstructor,
+  type TypedArrayConstructor,
+} from '@h5web/shared/vis-models';
 
-import { typedArrayFromDType } from '../utils';
+import { bigIntTypedArrayFromDType, typedArrayFromDType } from '../utils';
 import {
   type H5GroveAttribute,
   type H5GroveEntity,
@@ -232,7 +235,7 @@ export function parseDType(type: H5GroveType): DType {
  */
 export function h5groveTypedArrayFromDType(
   dtype: DType,
-): TypedArrayConstructor | undefined {
+): TypedArrayConstructor | BigIntTypedArrayConstructor | undefined {
   const { class: dtypeClass } = dtype;
 
   if (dtypeClass === DTypeClass.Float && dtype.size === 16) {
@@ -243,5 +246,5 @@ export function h5groveTypedArrayFromDType(
     return Float64Array;
   }
 
-  return typedArrayFromDType(dtype);
+  return typedArrayFromDType(dtype) || bigIntTypedArrayFromDType(dtype);
 }

packages/app/src/providers/utils.ts

@@ -11,7 +11,10 @@ import {
   type ScalarShape,
 } from '@h5web/shared/hdf5-models';
 import { type OnProgress } from '@h5web/shared/react-suspense-fetch';
-import { type TypedArrayConstructor } from '@h5web/shared/vis-models';
+import {
+  type BigIntTypedArrayConstructor,
+  type TypedArrayConstructor,
+} from '@h5web/shared/vis-models';
 import { type AxiosProgressEvent, isAxiosError } from 'axios';
 
 import { type DataProviderApi } from './api';
@@ -33,7 +36,7 @@ export function typedArrayFromDType(
         return Int16Array;
       case 32:
         return Int32Array;
-      case 64: // No support for 64-bit integer values in JS
+      case 64: // combine with `bigIntTypedArrayFromDType` when relevant
         return undefined;
     }
   }
@@ -46,14 +49,15 @@ export function typedArrayFromDType(
         return Uint16Array;
       case 32:
         return Uint32Array;
-      case 64: // No support for 64-bit unsigned integer values in JS
+      case 64: // combine with `bigIntTypedArrayFromDType` when relevant
         return undefined;
     }
   }
 
   if (isFloatType(dtype)) {
     switch (dtype.size) {
-      case 16: // No support for 16-bit floating values in JS
+      case 16: // no support for 16-bit floating values in JS
+      case 128: // no support for 128-bit floating values in JS
         return undefined;
       case 32:
         return Float32Array;
@@ -65,6 +69,16 @@ export function typedArrayFromDType(
   return undefined;
 }
 
+export function bigIntTypedArrayFromDType(
+  dtype: DType,
+): BigIntTypedArrayConstructor | undefined {
+  if (!isIntegerType(dtype) || dtype.size !== 64) {
+    return undefined;
+  }
+
+  return dtype.signed ? BigInt64Array : BigUint64Array;
+}
+
 export async function getValueOrError(
   api: DataProviderApi,
   dataset: Dataset<ArrayShape | ScalarShape>,

packages/app/src/vis-packs/core/hooks.ts

@@ -16,7 +16,10 @@ import { useMemo } from 'react';
 import { type DimensionMapping } from '../../dimension-mapper/models';
 import { isAxis } from '../../dimension-mapper/utils';
 import { useDataContext } from '../../providers/DataProvider';
-import { typedArrayFromDType } from '../../providers/utils';
+import {
+  bigIntTypedArrayFromDType,
+  typedArrayFromDType,
+} from '../../providers/utils';
 import {
   applyMapping,
   getBaseArray,
@@ -191,9 +194,12 @@ export function useIgnoreFillValue(dataset: Dataset): IgnoreValue | undefined {
   const rawFillValue = attrValuesStore.getSingle(dataset, '_FillValue');
 
   return useMemo(() => {
-    const DTypedArray = typedArrayFromDType(dataset.type);
     const wrappedFillValue = castArray(rawFillValue);
 
+    const DTypedArray = bigIntTypedArrayFromDType(dataset.type)
+      ? Float64Array // matches `useToNumArray` logic
+      : typedArrayFromDType(dataset.type);
+
     // Cast fillValue in the type of the dataset values to be able to use `===` for the comparison
     const fillValue =
       DTypedArray && typeof wrappedFillValue[0] === 'number'

packages/shared/src/vis-models.ts

@@ -22,6 +22,9 @@ export type TypedArrayConstructor =
   | Float64ArrayConstructor;
 
 export type BigIntTypedArray = MaybeBigInt64Array | MaybeBigUint64Array;
+export type BigIntTypedArrayConstructor =
+  | BigInt64ArrayConstructor
+  | BigUint64ArrayConstructor;
 
 export type Domain = [min: number, max: number];
 export type Axis = 'x' | 'y';