Merge pull request #1795 from silx-kit/screenshots

Downgrade Cypress to fix snapshots

Author: axelboc

.github/workflows/approve-snapshots.yml

@@ -54,7 +54,7 @@ jobs:
         run: pnpm build
 
       - name: Serve ⚡️
-        run: pnpm serve & pnpm dlx wait-on http://localhost:5173 -t 1m
+        run: pnpm serve & pnpm wait-on http://localhost:5173 -t 1m
 
       - name: Run Cypress 🌳
         run: pnpm cypress:run --env updateSnapshots=true

.prettierrc.json

@@ -1,3 +1,11 @@
 {
-  "singleQuote": true
+  "singleQuote": true,
+  "overrides": [
+    {
+      "files": "*.md",
+      "options": {
+        "proseWrap": "always"
+      }
+    }
+  ]
 }

CONTRIBUTING.md

@@ -453,6 +453,10 @@ rendering of the app depends on the GPU. For this reason, visual regression
 tests are run only on the CI. This is done through an environment variable
 called `CYPRESS_TAKE_SNAPSHOTS`.
 
+> Locally, we run the tests without snapshots in Firefox, since it's our main
+> target browser. On the CI, Firefox takes flaky snapshots, so we have to run
+> the tests in Electron instead.
+
 Visual regression tests may fail in the CI, either expectedly (e.g. when
 implementing a new feature) or unexpectedly (when detecting a regression). When
 this happens, the diff images and debug screenshots that Cypress generates are