Improve support for NetCDF fill value and valid range attributes#1956
Merged
Improve support for NetCDF fill value and valid range attributes#1956
Conversation
2393bd2 to
aa82dea
Compare
aa82dea to
c9b0912
Compare
Contributor
Author
|
/approve |
axelboc
commented
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1918
A while back, we added basic support for NetCDF's
_FillValueattribute.In this PR, I go a step further by implementing the spec more accurately, and by supporting three additional NetCDF attributes:
valid_min,valid_maxandvalid_range. These attributes are documented here: https://docs.unidata.ucar.edu/netcdf-c/current/attribute_conventions.html — the section on thevalid_rangeattribute actually talks about the order in which the attributes should be used. It also explains that_FillValueacts as an (invalid) upper or lower bound depending on if it's positive or negative.So in this PR:
valid_min,valid_maxandvalid_range.valid_min/max/rangeand_FillValueto the NX Line and NX Heatmap visualizations._FillValueacts as an invalid upper or lower bound (instead of just as an invalid exact value)._FillValuein line with the spec (i.e. difference lower than two epsilons).netcdfvisualization pack for the new code.