[core] remove cleanup for setSettings

Author: sim51

packages/core/src/hooks/useSetSettings.ts

@@ -1,4 +1,4 @@
-import { useEffect, useState } from "react";
+import { useCallback } from "react";
 import { Settings } from "sigma/settings";
 
 import { useSigmaContext } from "./context";
@@ -24,32 +24,18 @@ export function useSetSettings<
   E extends Attributes = Attributes,
   G extends Attributes = Attributes,
 >(): (newSettings: Partial<Settings<N, E, G>>) => void {
-  const { sigma, container } = useSigmaContext<N, E, G>();
-  const [settings, setSettings] = useState<Partial<Settings<N, E, G>>>({});
+  const { sigma } = useSigmaContext<N, E, G>();
 
-  useEffect(() => {
-    if (!sigma || !settings) {
-      return;
-    }
-
-    const prevSettings: Partial<Settings<N, E, G>> = {};
-
-    (Object.keys(settings) as Array<keyof Settings<N, E, G>>).forEach((key) => {
-      // as never because of https://stackoverflow.com/questions/58656353/how-to-avoid-dynamic-keyof-object-assign-error-in-typescript
-      prevSettings[key] = settings[key] as never;
-      sigma.setSetting(key, settings[key] as never);
-    });
-
-    // cleanup
-    return () => {
-      if (sigma && container && container.offsetWidth > 0 && container.offsetHeight > 0) {
-        (Object.keys(prevSettings) as Array<keyof Settings<N, E, G>>).forEach((key) => {
-          // as never because of https://stackoverflow.com/questions/58656353/how-to-avoid-dynamic-keyof-object-assign-error-in-typescript
-          sigma.setSetting(key, prevSettings[key] as never);
-        });
-      }
-    };
-  }, [sigma, settings, container]);
+  const setSettings = useCallback(
+    (newSettings: Partial<Settings<N, E, G>>) => {
+      if (!sigma) return;
+      (Object.keys(newSettings) as Array<keyof Settings<N, E, G>>).forEach((key) => {
+        // as never because of https://stackoverflow.com/questions/58656353/how-to-avoid-dynamic-keyof-object-assign-error-in-typescript
+        sigma.setSetting(key, newSettings[key] as never);
+      });
+    },
+    [sigma],
+  );
 
   return setSettings;
 }