Skip to content

Commit f5172bd

Browse files
committed
test: run on y24 lts
1 parent b680a8d commit f5172bd

File tree

2 files changed

+23
-13
lines changed

2 files changed

+23
-13
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ jobs:
7373
- "23.7"
7474
- "23.8"
7575
- "23.9"
76+
- "24.3"
77+
- "24.8"
7678
dependency-versions:
7779
- "highest"
7880
env:

tests/Param/ParamValueConverterRegistryTest.php

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ final class ParamValueConverterRegistryTest extends TestCaseBase
3030
{
3131
use WithClient;
3232

33+
private const VersionLineString = 2309;
34+
private const VersionVariant = 2309;
3335
private const VersionIntervalJson = 2301;
3436

3537
/** @var array<string> */
@@ -181,7 +183,10 @@ public static function providerConvert(): Generator
181183
yield 'Bool' => ['Bool', true, 'true'];
182184

183185
yield 'Dynamic' => ['Bool', true, 'true'];
184-
yield 'Variant' => ['Variant(String, Int8)', 'test', 'test'];
186+
187+
if (ClickHouseVersion::get() >= self::VersionVariant) {
188+
yield 'Variant' => ['Variant(String, Int8)', 'test', 'test'];
189+
}
185190

186191
yield 'Nullable' => ['Nullable(String)', 'foo', 'foo'];
187192
yield 'LowCardinality' => ['LowCardinality(String)', 'foo', 'foo'];
@@ -239,19 +244,22 @@ public static function providerConvert(): Generator
239244
yield 'Point (array)' => ['Point', [1, 2], '(1,2)'];
240245
yield 'Ring' => ['Ring', '[(1,2),(3,4)]', '[(1,2),(3,4)]'];
241246
yield 'Ring (array)' => ['Ring', [[1, 2], [3, 4]], '[(1,2),(3,4)]'];
242-
yield 'LineString' => ['LineString', '[(1,2),(3,4)]', '[(1,2),(3,4)]'];
243-
yield 'LineString (array)' => ['LineString', [[1, 2], [3, 4]], '[(1,2),(3,4)]'];
244-
yield 'MultiLineString' => [
245-
'MultiLineString',
246-
'[[(1,2),(3,4)],[(5,6),(7,8)]]',
247-
'[[(1,2),(3,4)],[(5,6),(7,8)]]',
248-
];
249247

250-
yield 'MultiLineString (array)' => [
251-
'MultiLineString',
252-
[[[1, 2], [3, 4]], [[5, 6], [7, 8]]],
253-
'[[(1,2),(3,4)],[(5,6),(7,8)]]',
254-
];
248+
if (ClickHouseVersion::get() >= self::VersionLineString) {
249+
yield 'LineString' => ['LineString', '[(1,2),(3,4)]', '[(1,2),(3,4)]'];
250+
yield 'LineString (array)' => ['LineString', [[1, 2], [3, 4]], '[(1,2),(3,4)]'];
251+
yield 'MultiLineString' => [
252+
'MultiLineString',
253+
'[[(1,2),(3,4)],[(5,6),(7,8)]]',
254+
'[[(1,2),(3,4)],[(5,6),(7,8)]]',
255+
];
256+
257+
yield 'MultiLineString (array)' => [
258+
'MultiLineString',
259+
[[[1, 2], [3, 4]], [[5, 6], [7, 8]]],
260+
'[[(1,2),(3,4)],[(5,6),(7,8)]]',
261+
];
262+
}
255263

256264
yield 'Polygon' => ['Polygon', '[[(1,2),(3,4)],[(5,6),(7,8)]]', '[[(1,2),(3,4)],[(5,6),(7,8)]]'];
257265
yield 'Polygon (array)' => ['Polygon', [[[1, 2], [3, 4]], [[5, 6], [7, 8]]], '[[(1,2),(3,4)],[(5,6),(7,8)]]'];

0 commit comments

Comments
 (0)