syslog/intbuffer: fix spinlock deadlock

anchao · xiaoxiang781216 · commit 0e1214d89ab4 · 2025-01-20T17:42:40.000+08:00
just read the code, still have the deadlock after below change: | commit 3b6f463 | Author: chenrun1 <chenrun1@xiaomi.com> | Date: Tue Dec 31 14:31:46 2024 +0800 | | syslog_inbuffer:Fixed the lock reentry issue in single core + spinlock scenario | | Summary: | When spinlock.h is enabled in a single-core scenario, spinlock reentry and exceptions may occur when spin_lock_irqsave_wo_note is used in syslog_add_intbuffer | | Signed-off-by: chenrun1 <chenrun1@xiaomi.com> Signed-off-by: chao an <anchao.archer@bytedance.com>
diff --git a/drivers/syslog/syslog_intbuffer.c b/drivers/syslog/syslog_intbuffer.c
@@ -165,7 +165,7 @@ void syslog_add_intbuffer(FAR const char *buffer, size_t buflen)
     }
   else
     {
-      syslog_flush_intbuffer(true);
+      syslog_flush_internal(true, sizeof(g_syslog_intbuffer.buffer));
       space = buflen - sizeof(g_syslog_intbuffer.buffer);
       syslog_write_foreach(buffer, space, true);
       circbuf_write(&g_syslog_intbuffer.circ,

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ void syslog_add_intbuffer(FAR const char *buffer, size_t buflen)`
`165`	`165`	`}`
`166`	`166`	`else`
`167`	`167`	`{`
`168`		`- syslog_flush_intbuffer(true);`
	`168`	`+ syslog_flush_internal(true, sizeof(g_syslog_intbuffer.buffer));`
`169`	`169`	`space = buflen - sizeof(g_syslog_intbuffer.buffer);`
`170`	`170`	`syslog_write_foreach(buffer, space, true);`
`171`	`171`	`circbuf_write(&g_syslog_intbuffer.circ,`