boards/nucleo-c0xxx: fix leds handling

raiden00pl · simbit18 · commit a3ada5ce3036 · 2025-12-21T14:08:38.000+01:00
Fix LED handling for nucleo-c092rc and nucleo-c071rb.
These boards have two LEDs but one is activated with HIGH the other is activated
with LOW.

Also fix userled registration.

Signed-off-by: raiden00pl &lt;raiden00@railab.me&gt;
diff --git a/boards/arm/stm32f0l0g0/nucleo-c071rb/src/nucleo-c071rb.h b/boards/arm/stm32f0l0g0/nucleo-c071rb/src/nucleo-c071rb.h
@@ -45,7 +45,7 @@
  */
 
 #define GPIO_LD1        (GPIO_OUTPUT | GPIO_PUSHPULL | GPIO_SPEED_MEDIUM | \
-                         GPIO_OUTPUT_SET | GPIO_PORTA | GPIO_PIN5)
+                         GPIO_OUTPUT_CLEAR | GPIO_PORTA | GPIO_PIN5)
 #define GPIO_LD2        (GPIO_OUTPUT | GPIO_PUSHPULL | GPIO_SPEED_MEDIUM | \
                          GPIO_OUTPUT_SET | GPIO_PORTC | GPIO_PIN9)
 
diff --git a/boards/arm/stm32f0l0g0/nucleo-c071rb/src/stm32_autoleds.c b/boards/arm/stm32f0l0g0/nucleo-c071rb/src/stm32_autoleds.c
@@ -50,8 +50,9 @@
 
 void board_autoled_initialize(void)
 {
-  /* Configure LD2 GPIO for output */
+  /* Configure LD1 and LD2 GPIO for output */
 
+  stm32_configgpio(GPIO_LD1);
   stm32_configgpio(GPIO_LD2);
 }
 
@@ -61,7 +62,12 @@ void board_autoled_initialize(void)
 
 void board_autoled_on(int led)
 {
-  if (led == 1)
+  if (led == BOARD_LED1)
+    {
+      stm32_gpiowrite(GPIO_LD1, true);
+    }
+
+  if (led == BOARD_LED2)
     {
       stm32_gpiowrite(GPIO_LD2, false);
     }
@@ -73,7 +79,12 @@ void board_autoled_on(int led)
 
 void board_autoled_off(int led)
 {
-  if (led == 1)
+  if (led == BOARD_LED1)
+    {
+      stm32_gpiowrite(GPIO_LD1, false);
+    }
+
+  if (led == BOARD_LED2)
     {
       stm32_gpiowrite(GPIO_LD2, true);
     }
diff --git a/boards/arm/stm32f0l0g0/nucleo-c071rb/src/stm32_bringup.c b/boards/arm/stm32f0l0g0/nucleo-c071rb/src/stm32_bringup.c
@@ -78,7 +78,7 @@ int stm32_bringup(void)
   stm32_iwdginitialize("/dev/watchdog0", STM32_LSI_FREQUENCY);
 #endif
 
-#ifdef HAVE_LEDS
+#if !defined(CONFIG_ARCH_LEDS) && defined(CONFIG_USERLED_LOWER)
   /* Register the LED driver */
 
   ret = userled_lower_initialize(LED_DRIVER_PATH);
diff --git a/boards/arm/stm32f0l0g0/nucleo-c071rb/src/stm32_userleds.c b/boards/arm/stm32f0l0g0/nucleo-c071rb/src/stm32_userleds.c
@@ -120,8 +120,9 @@ static int led_pm_prepare(struct pm_callback_s *cb, int domain,
 
 uint32_t board_userled_initialize(void)
 {
-  /* Configure LD2 GPIO for output */
+  /* Configure LD1 and LD2 GPIO for output */
 
+  stm32_configgpio(GPIO_LD1);
   stm32_configgpio(GPIO_LD2);
   return BOARD_NLEDS;
 }
@@ -132,9 +133,14 @@ uint32_t board_userled_initialize(void)
 
 void board_userled(int led, bool ledon)
 {
-  if (led == BOARD_LD2)
+  if (led == BOARD_LED1)
     {
-      stm32_gpiowrite(GPIO_LD2, ledon);
+      stm32_gpiowrite(GPIO_LD1, ledon);
+    }
+
+  if (led == BOARD_LED2)
+    {
+      stm32_gpiowrite(GPIO_LD2, !ledon);
     }
 }
 
@@ -144,7 +150,8 @@ void board_userled(int led, bool ledon)
 
 void board_userled_all(uint32_t ledset)
 {
-  stm32_gpiowrite(GPIO_LD2, (ledset & BOARD_LD2_BIT) != 0);
+  stm32_gpiowrite(GPIO_LD1, (ledset & BOARD_LED1_BIT) != 0);
+  stm32_gpiowrite(GPIO_LD2, (ledset & BOARD_LED2_BIT) == 0);
 }
 
 /****************************************************************************
diff --git a/boards/arm/stm32f0l0g0/nucleo-c092rc/src/nucleo-c092rc.h b/boards/arm/stm32f0l0g0/nucleo-c092rc/src/nucleo-c092rc.h
@@ -45,7 +45,7 @@
  */
 
 #define GPIO_LD1        (GPIO_OUTPUT | GPIO_PUSHPULL | GPIO_SPEED_MEDIUM | \
-                         GPIO_OUTPUT_SET | GPIO_PORTA | GPIO_PIN5)
+                         GPIO_OUTPUT_CLEAR | GPIO_PORTA | GPIO_PIN5)
 #define GPIO_LD2        (GPIO_OUTPUT | GPIO_PUSHPULL | GPIO_SPEED_MEDIUM | \
                          GPIO_OUTPUT_SET | GPIO_PORTC | GPIO_PIN9)
 
diff --git a/boards/arm/stm32f0l0g0/nucleo-c092rc/src/stm32_autoleds.c b/boards/arm/stm32f0l0g0/nucleo-c092rc/src/stm32_autoleds.c
@@ -50,8 +50,9 @@
 
 void board_autoled_initialize(void)
 {
-  /* Configure LD2 GPIO for output */
+  /* Configure LD1 and LD2 GPIO for output */
 
+  stm32_configgpio(GPIO_LD1);
   stm32_configgpio(GPIO_LD2);
 }
 
@@ -61,7 +62,12 @@ void board_autoled_initialize(void)
 
 void board_autoled_on(int led)
 {
-  if (led == 1)
+  if (led == BOARD_LED1)
+    {
+      stm32_gpiowrite(GPIO_LD1, true);
+    }
+
+  if (led == BOARD_LED2)
     {
       stm32_gpiowrite(GPIO_LD2, false);
     }
@@ -73,7 +79,12 @@ void board_autoled_on(int led)
 
 void board_autoled_off(int led)
 {
-  if (led == 1)
+  if (led == BOARD_LED1)
+    {
+      stm32_gpiowrite(GPIO_LD1, false);
+    }
+
+  if (led == BOARD_LED2)
     {
       stm32_gpiowrite(GPIO_LD2, true);
     }
diff --git a/boards/arm/stm32f0l0g0/nucleo-c092rc/src/stm32_bringup.c b/boards/arm/stm32f0l0g0/nucleo-c092rc/src/stm32_bringup.c
@@ -78,7 +78,7 @@ int stm32_bringup(void)
   stm32_iwdginitialize("/dev/watchdog0", STM32_LSI_FREQUENCY);
 #endif
 
-#ifdef HAVE_LEDS
+#if !defined(CONFIG_ARCH_LEDS) && defined(CONFIG_USERLED_LOWER)
   /* Register the LED driver */
 
   ret = userled_lower_initialize(LED_DRIVER_PATH);
diff --git a/boards/arm/stm32f0l0g0/nucleo-c092rc/src/stm32_userleds.c b/boards/arm/stm32f0l0g0/nucleo-c092rc/src/stm32_userleds.c
@@ -120,8 +120,9 @@ static int led_pm_prepare(struct pm_callback_s *cb, int domain,
 
 uint32_t board_userled_initialize(void)
 {
-  /* Configure LD2 GPIO for output */
+  /* Configure LD1 and LD2 GPIO for output */
 
+  stm32_configgpio(GPIO_LD1);
   stm32_configgpio(GPIO_LD2);
   return BOARD_NLEDS;
 }
@@ -132,9 +133,14 @@ uint32_t board_userled_initialize(void)
 
 void board_userled(int led, bool ledon)
 {
-  if (led == BOARD_LD2)
+  if (led == BOARD_LED1)
     {
-      stm32_gpiowrite(GPIO_LD2, ledon);
+      stm32_gpiowrite(GPIO_LD1, ledon);
+    }
+
+  if (led == BOARD_LED2)
+    {
+      stm32_gpiowrite(GPIO_LD2, !ledon);
     }
 }
 
@@ -144,7 +150,8 @@ void board_userled(int led, bool ledon)
 
 void board_userled_all(uint32_t ledset)
 {
-  stm32_gpiowrite(GPIO_LD2, (ledset & BOARD_LD2_BIT) != 0);
+  stm32_gpiowrite(GPIO_LD1, (ledset & BOARD_LED1_BIT) != 0);
+  stm32_gpiowrite(GPIO_LD2, (ledset & BOARD_LED2_BIT) == 0);
 }
 
 /****************************************************************************

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,9 @@`
`50`	`50`
`51`	`51`	`void board_autoled_initialize(void)`
`52`	`52`	`{`
`53`		`- /* Configure LD2 GPIO for output */`
	`53`	`+ /* Configure LD1 and LD2 GPIO for output */`
`54`	`54`
	`55`	`+ stm32_configgpio(GPIO_LD1);`
`55`	`56`	`stm32_configgpio(GPIO_LD2);`
`56`	`57`	`}`
`57`	`58`
`@@ -61,7 +62,12 @@ void board_autoled_initialize(void)`
`61`	`62`
`62`	`63`	`void board_autoled_on(int led)`
`63`	`64`	`{`
`64`		`- if (led == 1)`
	`65`	`+ if (led == BOARD_LED1)`
	`66`	`+ {`
	`67`	`+ stm32_gpiowrite(GPIO_LD1, true);`
	`68`	`+ }`
	`69`	`+`
	`70`	`+ if (led == BOARD_LED2)`
`65`	`71`	`{`
`66`	`72`	`stm32_gpiowrite(GPIO_LD2, false);`
`67`	`73`	`}`
`@@ -73,7 +79,12 @@ void board_autoled_on(int led)`
`73`	`79`
`74`	`80`	`void board_autoled_off(int led)`
`75`	`81`	`{`
`76`		`- if (led == 1)`
	`82`	`+ if (led == BOARD_LED1)`
	`83`	`+ {`
	`84`	`+ stm32_gpiowrite(GPIO_LD1, false);`
	`85`	`+ }`
	`86`	`+`
	`87`	`+ if (led == BOARD_LED2)`
`77`	`88`	`{`
`78`	`89`	`stm32_gpiowrite(GPIO_LD2, true);`
`79`	`90`	`}`
Original file line number	Diff line number	Diff line change
`@@ -120,8 +120,9 @@ static int led_pm_prepare(struct pm_callback_s *cb, int domain,`
`120`	`120`
`121`	`121`	`uint32_t board_userled_initialize(void)`
`122`	`122`	`{`
`123`		`- /* Configure LD2 GPIO for output */`
	`123`	`+ /* Configure LD1 and LD2 GPIO for output */`
`124`	`124`
	`125`	`+ stm32_configgpio(GPIO_LD1);`
`125`	`126`	`stm32_configgpio(GPIO_LD2);`
`126`	`127`	`return BOARD_NLEDS;`
`127`	`128`	`}`
`@@ -132,9 +133,14 @@ uint32_t board_userled_initialize(void)`
`132`	`133`
`133`	`134`	`void board_userled(int led, bool ledon)`
`134`	`135`	`{`
`135`		`- if (led == BOARD_LD2)`
	`136`	`+ if (led == BOARD_LED1)`
`136`	`137`	`{`
`137`		`- stm32_gpiowrite(GPIO_LD2, ledon);`
	`138`	`+ stm32_gpiowrite(GPIO_LD1, ledon);`
	`139`	`+ }`
	`140`	`+`
	`141`	`+ if (led == BOARD_LED2)`
	`142`	`+ {`
	`143`	`+ stm32_gpiowrite(GPIO_LD2, !ledon);`
`138`	`144`	`}`
`139`	`145`	`}`
`140`	`146`
`@@ -144,7 +150,8 @@ void board_userled(int led, bool ledon)`
`144`	`150`
`145`	`151`	`void board_userled_all(uint32_t ledset)`
`146`	`152`	`{`
`147`		`- stm32_gpiowrite(GPIO_LD2, (ledset & BOARD_LD2_BIT) != 0);`
	`153`	`+ stm32_gpiowrite(GPIO_LD1, (ledset & BOARD_LED1_BIT) != 0);`
	`154`	`+ stm32_gpiowrite(GPIO_LD2, (ledset & BOARD_LED2_BIT) == 0);`
`148`	`155`	`}`
`149`	`156`
`150`	`157`	`/****************************************************************************`