drivers/lcd/st7789.c: fix byte order in st7789_fill for 3 wires

michallenc · jerpelea · commit bf391cc2bc46 · 2025-12-03T14:36:46.000+01:00
The bytes of color should be sent in an opposite order in st7789_fill
function if the driver operates in 3 wire mode.

Signed-off-by: Michal Lenc &lt;michallenc@seznam.cz&gt;
diff --git a/drivers/lcd/st7789.c b/drivers/lcd/st7789.c
@@ -717,8 +717,8 @@ static void st7789_fill(FAR struct st7789_dev_s *dev, uint16_t color)
 
   for (i = 0; i < ST7789_XRES * ST7789_YRES; i++)
     {
-      SPI_SEND(dev->spi, LCD_ST7789_DATA_PREFIX | (color & 0xff));
       SPI_SEND(dev->spi, LCD_ST7789_DATA_PREFIX | (color & 0xff00) >> 8);
+      SPI_SEND(dev->spi, LCD_ST7789_DATA_PREFIX | (color & 0xff));
     }
 #else
   st7789_select(dev->spi, ST7789_BYTESPP * LCD_ST7789_SPI_BITS);

Original file line number	Diff line number	Diff line change
`@@ -717,8 +717,8 @@ static void st7789_fill(FAR struct st7789_dev_s *dev, uint16_t color)`
`717`	`717`
`718`	`718`	`for (i = 0; i < ST7789_XRES * ST7789_YRES; i++)`
`719`	`719`	`{`
`720`		`- SPI_SEND(dev->spi, LCD_ST7789_DATA_PREFIX \| (color & 0xff));`
`721`	`720`	`SPI_SEND(dev->spi, LCD_ST7789_DATA_PREFIX \| (color & 0xff00) >> 8);`
	`721`	`+ SPI_SEND(dev->spi, LCD_ST7789_DATA_PREFIX \| (color & 0xff));`
`722`	`722`	`}`
`723`	`723`	`#else`
`724`	`724`	`st7789_select(dev->spi, ST7789_BYTESPP * LCD_ST7789_SPI_BITS);`