cleanup

Signed-off-by: Heinz N. Gies <[email protected]>

Author: Licenser

Cargo.toml

@@ -14,7 +14,7 @@ rust-version = "1.88"
 [dependencies]
 simdutf8 = { version = "0.1.4", features = ["public_imp", "aarch64_neon"] }
 
-value-trait = { version = "0.11" }
+value-trait = { version = "0.12" }
 beef = { version = "0.5", optional = true }
 halfbrown = "0.4"
 # ahash known key

src/impls/neon/stage1.rs

@@ -204,7 +204,7 @@ impl Stage1Parse for SimdInput {
             base.reserve(64);
             let final_len = l + cnt;
 
-            let is_unaligned = l % 4 != 0;
+            let is_unaligned = !l.is_multiple_of(4);
             let write_fn = if is_unaligned {
                 std::ptr::write_unaligned
             } else {

src/macros.rs

@@ -1248,16 +1248,6 @@ macro_rules! static_cast_i64 {
 }
 pub(crate) use static_cast_i64;
 
-/// static cast to an i64
-#[cfg(all(feature = "approx-number-parsing", feature = "i128"))]
-macro_rules! static_cast_i128 {
-    ($v:expr_2021) => {
-        ::std::mem::transmute::<_, i128>($v)
-    };
-}
-#[cfg(all(feature = "approx-number-parsing", feature = "i128"))]
-pub(crate) use static_cast_i128;
-
 /// static cast to an u64
 macro_rules! static_cast_u64 {
     ($v:expr_2021) => {

src/numberparse/approx.rs

@@ -336,7 +336,7 @@ impl Deserializer<'_> {
                 ErrorType::InvalidNumber,
             ))
         } else if negative {
-            let i = unsafe { static_cast_i128!(i.wrapping_neg()) };
+            let i: i128 = i.wrapping_neg().cast_signed();
             if let Ok(i) = i64::try_from(i) {
                 Ok(StaticNode::I64(i))
             } else {

src/tests.rs

@@ -166,7 +166,7 @@ fn silly_float1() {
 }
 
 #[test]
-#[ignore]
+#[ignore = "serde is less precise on this test"]
 fn silly_float2() {
     let v = Value::from(-6.990_585_694_841_803e305);
     let s = v.encode();

src/tests/serde.rs

@@ -585,8 +585,7 @@ fn float1() {
     assert_eq!(v_simd, v_serde);
 }
 
-// We ignore this since serde is less precise on this test
-#[ignore]
+#[ignore = "We ignore this since serde is less precise on this test"]
 #[test]
 fn float2() {
     let mut d = String::from("-4.5512678569607477e306");