Allow non IOS builds (for our dev tools)

[colbyn]

This check in build.rs breaks my development tools.
I.e. !target.contains("apple-ios") in:

fn main() {
    let target = std::env::var("TARGET").unwrap();
    if !target.contains("apple-ios") { 
        panic!("uikit-sys requires the ios target");
    }

    let directory = sdk_path(&target).ok();
    build(directory.as_ref().map(String::as_ref), &target);
}

I believe the rust wasm bindgen team just implemented stubs for non WebAssembly targets. Can this library do the same?

[simlay]

Hi! Sorry for the late response, clearly something is wrong with my github notifications.

I believe the rust wasm bindgen team just implemented stubs for non WebAssembly targets. Can this library do the same?

Hmm. I suppose that could be done. It will just produce an empty lib.

I'm curious how it breaks your development tools.

[colbyn]

@simlay Oh I don't have the error on hand (I decided against using rust for this purpose). But form looking at my snippet, you can see that it'll panic (see the line panic!("uikit-sys requires the ios target");):

fn main() {
    let target = std::env::var("TARGET").unwrap();
    if !target.contains("apple-ios") { 
        panic!("uikit-sys requires the ios target");
    }

    let directory = sdk_path(&target).ok();
    build(directory.as_ref().map(String::as_ref), &target);
}

This will cause the build to fail and therefore your rust development tools will report an error.

Regarding

Hmm. I suppose that could be done. It will just produce an empty lib.

This isn't necessarily any better, because as soon as you try to reference something from the library, you'll get an undefined error (and obviously no autocomplete). What you want is to produce the same symbols as just stubs that fail when you try to call such at runtime. This is (if I can recall correctly) what the WASM bindgen team does.

Update: for an example, running cargo check (which is used by e.g. rust analyzer) yields:

   Compiling uikit-sys v0.0.1 (/Users/colbyn/Scratch/uikit-sys)
error: failed to run custom build command for `uikit-sys v0.0.1 (/Users/colbyn/Scratch/uikit-sys)`

Caused by:
  process didn't exit successfully: `/Users/colbyn/Scratch/uikit-sys/target/debug/build/uikit-sys-0d40961a6e9dc9ce/build-script-build` (exit code: 101)
  --- stderr
  thread 'main' panicked at 'uikit-sys requires the ios target', build.rs:85:9
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace