Revert "Merge branch 'dispose-database-tracker' into develop"

This reverts commit a441069, reversing
changes made to fcb7d78.

Author: simolus3

drift/CHANGELOG.md

@@ -7,7 +7,6 @@
   JSON.
 - Add `runWithInterceptor` method to databases to only apply interceptors in
   a restricted block.
-- Add `dispose()` method to `DatabaseTracker` to explicitly release in-memory SQLite resources.
 
 ## 2.23.1
 

drift/lib/native.dart

@@ -356,12 +356,10 @@ class _NativeDelegate extends Sqlite3Delegate<Database> {
       }
 
       db = sqlite3.open(file.path);
-      if (!tracker.isDisposed) {
-        try {
-          tracker.markOpened(file.path, db);
-        } on SqliteException {
-          // ignore
-        }
+      try {
+        tracker.markOpened(file.path, db);
+      } on SqliteException {
+        // ignore
       }
     } else {
       db = sqlite3.openInMemory();
@@ -401,12 +399,10 @@ class _NativeDelegate extends Sqlite3Delegate<Database> {
     await super.close();
 
     if (closeUnderlyingWhenClosed) {
-      if (!tracker.isDisposed) {
-        try {
-          tracker.markClosed(database);
-        } on SqliteException {
-          // ignore
-        }
+      try {
+        tracker.markClosed(database);
+      } on SqliteException {
+        // ignore
       }
 
       database.dispose();

drift/lib/src/sqlite3/database_tracker.dart

@@ -23,10 +23,6 @@ final DatabaseTracker tracker = DatabaseTracker();
 /// this is necessary.
 class DatabaseTracker {
   final Database _db;
-  bool _isDisposed = false;
-
-  /// Whether this [DatabaseTracker] has been disposed.
-  bool get isDisposed => _isDisposed;
 
   /// Creates a new tracker with necessary tables.
   DatabaseTracker()
@@ -42,35 +38,24 @@ CREATE TABLE IF NOT EXISTS open_connections(
     ''');
   }
 
-  /// Tracks the [openedDb]. The [path] argument can be used to track
-  /// the path of that database, if it's bound to a file.
-  ///
-  /// Throws a [StateError] if this tracker has already been disposed.
+  /// Tracks the [openedDb]. The [path] argument can be used to track the path
+  /// of that database, if it's bound to a file.
   void markOpened(String path, Database openedDb) {
-    _checkIfDisposed();
-
     final stmt = _db.prepare('INSERT INTO open_connections VALUES (?, ?)');
     stmt.execute([openedDb.handle.address, path]);
     stmt.dispose();
   }
 
   /// Marks the database [db] as closed.
-  ///
-  /// Throws a [StateError] if this tracker has already been disposed.
   void markClosed(Database db) {
-    _checkIfDisposed();
-
     final ptr = db.handle.address;
     _db.execute('DELETE FROM open_connections WHERE database_pointer = $ptr');
   }
 
-  /// Closes all tracked database connections that are still open.
-  ///
-  /// Throws a [StateError] if this tracker has already been disposed.
+  /// Closes tracked database connections.
   void closeExisting() {
-    _checkIfDisposed();
-
     _db.execute('BEGIN;');
+
     try {
       final results =
           _db.select('SELECT database_pointer FROM open_connections');
@@ -85,30 +70,4 @@ CREATE TABLE IF NOT EXISTS open_connections(
       _db.execute('COMMIT;');
     }
   }
-
-  /// Releases all open database handles managed by this tracker and
-  /// closes the internal in-memory database.
-  ///
-  /// After calling this method, this instance should no longer be used.
-  /// Any further calls to public methods will throw a [StateError].
-  void dispose() {
-    if (_isDisposed) {
-      return;
-    }
-
-    // Safely close any tracked connections
-    closeExisting();
-
-    _db.dispose();
-    _isDisposed = true;
-  }
-
-  /// Checks if this tracker has been disposed and throws a [StateError] if so.
-  void _checkIfDisposed() {
-    if (_isDisposed) {
-      throw StateError(
-        'DatabaseTracker has already been disposed and can no longer be used.',
-      );
-    }
-  }
 }