Clean up excessive ai comments

Author: simolus3

drift/lib/native.dart

@@ -356,10 +356,12 @@ class _NativeDelegate extends Sqlite3Delegate<Database> {
       }
 
       db = sqlite3.open(file.path);
-      try {
-        tracker.markOpened(file.path, db);
-      } on SqliteException {
-        // ignore
+      if (!tracker.isDisposed) {
+        try {
+          tracker.markOpened(file.path, db);
+        } on SqliteException {
+          // ignore
+        }
       }
     } else {
       db = sqlite3.openInMemory();
@@ -399,10 +401,12 @@ class _NativeDelegate extends Sqlite3Delegate<Database> {
     await super.close();
 
     if (closeUnderlyingWhenClosed) {
-      try {
-        tracker.markClosed(database);
-      } on SqliteException {
-        // ignore
+      if (!tracker.isDisposed) {
+        try {
+          tracker.markClosed(database);
+        } on SqliteException {
+          // ignore
+        }
       }
 
       database.dispose();

drift/lib/src/sqlite3/database_tracker.dart

@@ -23,11 +23,9 @@ final DatabaseTracker tracker = DatabaseTracker();
 /// this is necessary.
 class DatabaseTracker {
   final Database _db;
-
-  /// Whether this [DatabaseTracker] has been disposed.
   bool _isDisposed = false;
 
-  /// Public getter to check if this tracker has been disposed.
+  /// Whether this [DatabaseTracker] has been disposed.
   bool get isDisposed => _isDisposed;
 
   /// Creates a new tracker with necessary tables.
@@ -68,7 +66,6 @@ CREATE TABLE IF NOT EXISTS open_connections(
 
   /// Closes all tracked database connections that are still open.
   ///
-  /// This operation is wrapped in a transaction (`BEGIN` ... `COMMIT`).
   /// Throws a [StateError] if this tracker has already been disposed.
   void closeExisting() {
     _checkIfDisposed();
@@ -102,10 +99,7 @@ CREATE TABLE IF NOT EXISTS open_connections(
     // Safely close any tracked connections
     closeExisting();
 
-    // Dispose of the in-memory tracker database
     _db.dispose();
-
-    // Mark this tracker as disposed
     _isDisposed = true;
   }
 

drift/test/database/database_tracker_test.dart

@@ -3,70 +3,61 @@ import 'package:sqlite3/sqlite3.dart';
 import 'package:drift/src/sqlite3/database_tracker.dart';
 
 void main() {
-  group('DatabaseTracker', () {
-    late DatabaseTracker tracker;
+  late DatabaseTracker tracker;
 
-    setUp(() {
-      // Create a fresh DatabaseTracker instance before each test.
-      tracker = DatabaseTracker();
-    });
-
-    tearDown(() {
-      // Clean up resources by disposing of the tracker.
-      // Multiple dispose calls should be safe.
-      tracker.dispose();
-    });
-
-    test('tracks and closes existing database connections', () {
-      // Open two in-memory SQLite databases.
-      final db1 = sqlite3.openInMemory();
-      final db2 = sqlite3.openInMemory();
-
-      // Register each database with the tracker.
-      tracker.markOpened('db1_path', db1);
-      tracker.markOpened('db2_path', db2);
-
-      // Optionally perform some queries to confirm the databases are working.
-      db1.execute('CREATE TABLE test1 (id INTEGER NOT NULL PRIMARY KEY)');
-      db2.execute('CREATE TABLE test2 (id INTEGER NOT NULL PRIMARY KEY)');
+  setUp(() {
+    tracker = DatabaseTracker();
+  });
 
-      // Use the tracker to close all tracked connections.
-      tracker.closeExisting();
+  tearDown(() {
+    tracker.dispose();
+  });
 
-      // After closing, further queries should throw an error.
-      expect(
-            () => db1.execute('INSERT INTO test1 (id) VALUES (1)'),
-        throwsA(anything),
-      );
-      expect(
-            () => db2.execute('INSERT INTO test2 (id) VALUES (2)'),
-        throwsA(anything),
-      );
-    });
+  test('tracks and closes existing database connections', () {
+    // Open two in-memory SQLite databases.
+    final db1 = sqlite3.openInMemory();
+    final db2 = sqlite3.openInMemory();
+
+    // Register each database with the tracker.
+    tracker.markOpened('db1_path', db1);
+    tracker.markOpened('db2_path', db2);
+
+    // Use the tracker to close all tracked connections.
+    tracker.closeExisting();
+
+    // After closing, further queries should throw an error.
+    expect(
+      () => db1.execute('INSERT INTO test1 (id) VALUES (1)'),
+      throwsA(anything),
+    );
+    expect(
+      () => db2.execute('INSERT INTO test2 (id) VALUES (2)'),
+      throwsA(anything),
+    );
+  });
 
-    test('throws StateError after disposal', () {
-      // Dispose immediately
-      tracker.dispose();
+  test('throws StateError after disposal', () {
+    // Dispose immediately
+    tracker.dispose();
 
-      // Any usage of the tracker after dispose should throw a StateError.
-      expect(
-            () => tracker.markOpened('test', sqlite3.openInMemory()),
-        throwsStateError,
-      );
-      expect(() => tracker.closeExisting(), throwsStateError);
-    });
+    // Any usage of the tracker after dispose should throw a StateError.
+    expect(
+      () => tracker.markOpened('test', sqlite3.openInMemory()),
+      throwsStateError,
+    );
+    expect(() => tracker.closeExisting(), throwsStateError);
+  });
 
-    test('multiple calls to dispose are safe', () {
-      // Dispose can be called multiple times without throwing errors.
-      expect(() => tracker.dispose(), returnsNormally);
-      expect(() => tracker.dispose(), returnsNormally);
-    });
+  test('multiple calls to dispose are safe', () {
+    // Dispose can be called multiple times without throwing errors.
+    expect(() => tracker.dispose(), returnsNormally);
+    expect(() => tracker.dispose(), returnsNormally);
+  });
 
-    test('isDisposed reflects tracker state', () {
-      expect(tracker.isDisposed, isFalse);
+  test('isDisposed reflects tracker state', () {
+    expect(tracker.isDisposed, isFalse);
 
-      tracker.dispose();
-      expect(tracker.isDisposed, isTrue);
-    });
+    tracker.dispose();
+    expect(tracker.isDisposed, isTrue);
   });
 }