move reference type matchto linter

Author: dickermoshe

drift_dev/lib/src/analysis/driver/error.dart

@@ -4,39 +4,45 @@ import 'package:source_gen/source_gen.dart';
 import 'package:source_span/source_span.dart';
 import 'package:sqlparser/sqlparser.dart' as sql;
 
+enum DriftAnalysisErrorLevel { warning, error }
+
 class DriftAnalysisError {
   final SourceSpan? span;
   final String message;
+  final DriftAnalysisErrorLevel level;
 
-  DriftAnalysisError(this.span, this.message);
+  DriftAnalysisError(this.span, this.message,
+      {this.level = DriftAnalysisErrorLevel.error});
 
   factory DriftAnalysisError.forDartElement(
-      dart.Element element, String message) {
-    return DriftAnalysisError(
-      spanForElement(element),
-      message,
-    );
+      dart.Element element, String message,
+      {DriftAnalysisErrorLevel level = DriftAnalysisErrorLevel.error}) {
+    return DriftAnalysisError(spanForElement(element), message, level: level);
   }
 
   factory DriftAnalysisError.inDartAst(
-      dart.Element element, dart.SyntacticEntity entity, String message) {
-    return DriftAnalysisError(dartAstSpan(element, entity), message);
+      dart.Element element, dart.SyntacticEntity entity, String message,
+      {DriftAnalysisErrorLevel level = DriftAnalysisErrorLevel.error}) {
+    return DriftAnalysisError(dartAstSpan(element, entity), message,
+        level: level);
   }
 
   factory DriftAnalysisError.inDriftFile(
-      sql.SyntacticEntity sql, String message) {
-    return DriftAnalysisError(sql.span, message);
+      sql.SyntacticEntity sql, String message,
+      {DriftAnalysisErrorLevel level = DriftAnalysisErrorLevel.error}) {
+    return DriftAnalysisError(sql.span, message, level: level);
   }
 
-  factory DriftAnalysisError.fromSqlError(sql.AnalysisError error) {
+  factory DriftAnalysisError.fromSqlError(sql.AnalysisError error,
+      {DriftAnalysisErrorLevel level = DriftAnalysisErrorLevel.error}) {
     var message = error.message ?? '';
     if (error.type == sql.AnalysisErrorType.notSupportedInDesiredVersion) {
       message =
           '$message\nNote: You can change the assumed sqlite version with build '
           'options. See https://drift.simonbinder.eu/options/#assumed-sql-environment for details!';
     }
 
-    return DriftAnalysisError(error.span, message);
+    return DriftAnalysisError(error.span, message, level: level);
   }
 
   @override

drift_dev/lib/src/analysis/resolver/dart/column.dart

@@ -507,6 +507,7 @@ class ColumnParser {
         customConstraints: foundCustomConstraint,
         referenceName: _readReferenceName(element),
       ),
+      element: element,
       referencesColumnInSameTable: referencesColumnInSameTable,
     );
   }
@@ -665,5 +666,8 @@ class PendingColumnInformation {
   /// this column in that case.
   final String? referencesColumnInSameTable;
 
-  PendingColumnInformation(this.column, {this.referencesColumnInSameTable});
+  final Element element;
+
+  PendingColumnInformation(this.column,
+      {this.referencesColumnInSameTable, required this.element});
 }

drift_dev/lib/src/analysis/resolver/dart/table.dart

@@ -41,6 +41,16 @@ class DartTableResolver extends LocalElementResolver<DiscoveredDartTable> {
       } else {
         for (final constraint in column.column.constraints) {
           if (constraint is ForeignKeyReference) {
+            if (column.column.sqlType.builtin !=
+                    constraint.otherColumn.sqlType.builtin ||
+                column.column.typeConverter?.dartType !=
+                    constraint.otherColumn.typeConverter?.dartType) {
+              print(
+                  "The Manager API can only generate filters and orderings for relations where the types are exactly the same.");
+              reportError(DriftAnalysisError.forDartElement(column.element,
+                  "This column references a column whose type doesn't match this one. The generated managers will ignore this relation",
+                  level: DriftAnalysisErrorLevel.warning));
+            }
             references.add(constraint.otherColumn.owner);
           }
         }

drift_dev/lib/src/lints/drift_backend_errors.dart

@@ -8,6 +8,7 @@ import 'package:analyzer/error/error.dart' hide LintCode;
 import 'package:analyzer/error/listener.dart';
 import 'package:custom_lint_builder/custom_lint_builder.dart';
 import 'package:drift_dev/src/analysis/backend.dart';
+import 'package:drift_dev/src/analysis/driver/error.dart';
 import 'package:drift_dev/src/analysis/options.dart';
 import 'package:logging/logging.dart';
 
@@ -25,6 +26,11 @@ class DriftBuildErrors extends DartLintRule {
     errorSeverity: ErrorSeverity.ERROR,
   );
 
+  LintCode get _codeAsWarning => LintCode(
+      name: _code.name,
+      problemMessage: _code.problemMessage,
+      errorSeverity: ErrorSeverity.WARNING);
+
   @override
   void run(CustomLintResolver resolver, ErrorReporter reporter,
       CustomLintContext context) async {
@@ -35,7 +41,12 @@ class DriftBuildErrors extends DartLintRule {
     final file = await driver.fullyAnalyze(unit.uri);
     for (final error in file.allErrors) {
       if (error.span case final span?) {
-        reporter.reportErrorForSpan(_code, span, [error.message.trim()]);
+        reporter.reportErrorForSpan(
+            error.level == DriftAnalysisErrorLevel.warning
+                ? _codeAsWarning
+                : _code,
+            span,
+            [error.message.trim()]);
       }
     }
   }

drift_dev/lib/src/writer/manager/table_manager_writer.dart

@@ -104,16 +104,7 @@ class _TableManagerWriter {
 
       final currentType = typeForColumn(relation.currentColumn);
       final referencedType = typeForColumn(relation.referencedColumn);
-      if (currentType != referencedType) {
-        print(
-            "\"${relation.currentTable.baseDartName}.${relation.currentColumn.nameInSql}\" has a type of \"$currentType\""
-            " and \"${relation.referencedTable.baseDartName}.${relation.referencedColumn.nameInSql}\" has a type of \"$referencedType\"."
-            " Filters, orderings and reference getters for this relation wont be generated."
-            " The Manager API can only generate filters and orderings for relations where the types are exactly the same."
-            " If you aren't using the Manager API, you can ignore this message.");
-        return false;
-      }
-      return true;
+      return currentType == referencedType;
     }).toList();
 
     final columnFilters = <String>[];

drift_dev/test/linter_test/pkg/lib/db.dart

@@ -9,14 +9,27 @@ class Users extends Table {
   late final age = integer();
   // ignore: drift_build_errors
   late final age2 = integer()();
+  // expect_lint: drift_build_errors
+  late final group = integer().references(Group, #id)();
+  // expect_lint: drift_build_errors
+  late final group2 = integer().references(Group, #id)();
+}
+
+extension type PK(String id) {}
+
+class Group extends Table {
+  late final id = text() //
+      .map(TypeConverter.extensionType<PK, String>())();
+  late final id2 = integer() //
+      .map(TypeConverter.extensionType<PK, int>())();
 }
 
 class BrokenTable extends Table {
   // expect_lint: drift_build_errors
   IntColumn get unknownRef => integer().customConstraint('CHECK foo > 10')();
 }
 
-@DriftDatabase(tables: [Users])
+@DriftDatabase(tables: [Users, Group])
 class TestDatabase extends _$TestDatabase {
   TestDatabase(super.e);
 
@@ -46,7 +59,8 @@ class TestDatabase extends _$TestDatabase {
     transaction(
       () async {
         // expect_lint: unawaited_futures_in_transaction
-        into(users).insert(UsersCompanion.insert(name: 'name'));
+        into(users)
+            .insert(UsersCompanion.insert(name: 'name', age2: 1, group: 5));
       },
     );
   }