Unskip session tests on Windows

Author: simolus3

sqlite3/lib/src/session.dart

@@ -14,6 +14,18 @@ import 'sqlite3.dart';
 ///
 /// {@category common}
 abstract interface class Session {
+  /// Creates a new session on the given [CommonDatabase] and the optional
+  /// [name] of the schema to track.
+  ///
+  /// __Important__: While `package:sqlite3` uses native finalizers on both the
+  /// database and the session object to ensure they're cleared automatically
+  /// once they're no longer used in Dart, the order in which the objects are
+  /// cleared matters. It is important that the session is closed is before the
+  /// database, closing it afterwards may crash.
+  ///
+  /// This ordering can't be guaranteed with native finalizers alone. For this
+  /// reason, returned [Session]s should be [Session.delete]d explicitly as soon
+  /// as they're no longer needed.
   factory Session(CommonDatabase database, {String name = 'main'}) {
     final asImpl = database as DatabaseImplementation;
     return SessionImplementation.createSession(asImpl, name);

sqlite3/test/common/session.dart

@@ -21,13 +21,22 @@ void testSession(FutureOr<CommonSqlite3> Function() loadSqlite) {
   });
   tearDown(() => database.dispose());
 
-  test('enabled by default', () {
+  Session createSession() {
     final session = Session(database);
+    // Ensure we close the session before disposing the database. SQLite
+    // mentions that session objects should be closed before the database, and
+    // that closing them afterwards is UB.
+    addTearDown(session.delete);
+    return session;
+  }
+
+  test('enabled by default', () {
+    final session = createSession();
     expect(session.enabled, isTrue);
   });
 
   test('isEmpty', () {
-    final session = Session(database);
+    final session = createSession();
     expect(session.isEmpty, isTrue);
     expect(session.isNotEmpty, isFalse);
 
@@ -45,7 +54,7 @@ void testSession(FutureOr<CommonSqlite3> Function() loadSqlite) {
   });
 
   test('attaching to some tables only', () {
-    final session = Session(database);
+    final session = createSession();
     expect(session.isEmpty, isTrue);
     session.attach('entries');
     database.execute('INSERT INTO other (content) VALUES (?);', [
@@ -56,7 +65,7 @@ void testSession(FutureOr<CommonSqlite3> Function() loadSqlite) {
   });
 
   test('iterator', () {
-    final session = Session(database)..attach();
+    final session = createSession()..attach();
     database
       ..execute('INSERT INTO entries (content) VALUES (?);', ['a'])
       ..execute('UPDATE entries SET content = ?', ['b']);
@@ -89,7 +98,7 @@ void testSession(FutureOr<CommonSqlite3> Function() loadSqlite) {
   });
 
   test('changeset invert', () {
-    final session = Session(database)..attach();
+    final session = createSession()..attach();
     database.execute('INSERT INTO entries (content) VALUES (?);', ['a']);
 
     final changeset = session.changeset();
@@ -111,7 +120,7 @@ void testSession(FutureOr<CommonSqlite3> Function() loadSqlite) {
   });
 
   test('apply changeset', () {
-    final session = Session(database)..attach();
+    final session = createSession()..attach();
     database.execute('INSERT INTO entries (content) VALUES (?);', ['a']);
     final changeset = session.changeset();
     session.delete();
@@ -126,7 +135,7 @@ void testSession(FutureOr<CommonSqlite3> Function() loadSqlite) {
   });
 
   test('apply patchset', () {
-    final session = Session(database)..attach();
+    final session = createSession()..attach();
     database.execute('INSERT INTO entries (content) VALUES (?);', ['a']);
     final patchset = session.patchset();
     session.delete();
@@ -140,7 +149,7 @@ void testSession(FutureOr<CommonSqlite3> Function() loadSqlite) {
   });
 
   test('diff', () {
-    var session = Session(database);
+    var session = createSession();
     database.execute('INSERT INTO entries (content) VALUES (?);', ['a']);
 
     database
@@ -150,7 +159,7 @@ void testSession(FutureOr<CommonSqlite3> Function() loadSqlite) {
       )
       ..execute('INSERT INTO another.entries (content) VALUES (?);', ['b']);
 
-    session = Session(database)..diff('another', 'entries');
+    session = createSession()..diff('another', 'entries');
     final changeset = session.changeset();
     expect(changeset.toList(), [
       isOp(

sqlite3/test/ffi/common_database_test.dart

@@ -1,8 +1,6 @@
 @Tags(['ffi'])
 library;
 
-import 'dart:io';
-
 import 'package:sqlite3/sqlite3.dart';
 import 'package:test/scaffolding.dart';
 
@@ -20,12 +18,7 @@ void main() {
     hasSharedCache: hasSharedCache,
   );
 
-  if (!Platform.isWindows) {
-    // TODO: Something is wrong with session tests on Windows, but I couldn't
-    // reproduce the issue in a VM yet.
-
-    group('session', () {
-      testSession(() => sqlite3);
-    }, skip: hasSession ? false : 'Missing session extension');
-  }
+  group('session', () {
+    testSession(() => sqlite3);
+  }, skip: hasSession ? false : 'Missing session extension');
 }