Remove quoteIdentifierInFragment from Platform, no remaining callers

Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>

Author: simon-mundy

src/Adapter/Platform/AbstractPlatform.php

@@ -11,9 +11,7 @@
 
 use function addcslashes;
 use function array_map;
-use function ctype_alpha;
 use function implode;
-use function preg_replace;
 use function str_replace;
 
 /**
@@ -28,55 +26,9 @@ abstract class AbstractPlatform implements PlatformInterface
 
     protected bool $quoteIdentifiers = true;
 
-    /** SQL keywords that must not be quoted in identifier fragments */
-    protected const KEYWORDS_PATTERN = 'AS|AND|OR|BETWEEN';
-
     /** @var array<string, string> */
     private array $identifierCache = [];
 
-    /**
-     * {@inheritDoc}
-     *
-     * @param string[] $additionalSafeWords
-     */
-    #[Override]
-    public function quoteIdentifierInFragment(string $identifier, array $additionalSafeWords = []): string
-    {
-        if (! $this->quoteIdentifiers) {
-            return $identifier;
-        }
-
-        $cacheKey = $identifier;
-        $pattern  = self::KEYWORDS_PATTERN;
-
-        if ($additionalSafeWords !== []) {
-            $extra = [];
-            foreach ($additionalSafeWords as $word) {
-                if (ctype_alpha($word)) {
-                    $extra[] = $word;
-                }
-            }
-            if ($extra !== []) {
-                $extraPattern = implode('|', $extra);
-                $pattern     .= '|' . $extraPattern;
-                $cacheKey    .= "\0" . $extraPattern;
-            }
-        }
-
-        if (isset($this->identifierCache[$cacheKey])) {
-            return $this->identifierCache[$cacheKey];
-        }
-
-        /** @var string $result */
-        $result = preg_replace(
-            '/\b(?!(?:' . $pattern . ')\b)([a-zA-Z_]\w*+)(?!\s*\()/i',
-            $this->quoteIdentifier[0] . '$1' . $this->quoteIdentifier[1],
-            $identifier
-        );
-
-        return $this->identifierCache[$cacheKey] = $result;
-    }
-
     /**
      * {@inheritDoc}
      */

src/Adapter/Platform/PlatformInterface.php

@@ -68,9 +68,4 @@ public function quoteValueList(array|string $valueList): string;
      * Get identifier separator
      */
     public function getIdentifierSeparator(): string;
-
-    /**
-     * Quote identifier in fragment
-     */
-    public function quoteIdentifierInFragment(string $identifier, array $additionalSafeWords = []): string;
 }

test/unit/Adapter/Platform/Sql92Test.php

@@ -19,7 +19,6 @@
 #[CoversMethod(Sql92::class, 'quoteTrustedValue')]
 #[CoversMethod(Sql92::class, 'quoteValueList')]
 #[CoversMethod(Sql92::class, 'getIdentifierSeparator')]
-#[CoversMethod(Sql92::class, 'quoteIdentifierInFragment')]
 final class Sql92Test extends TestCase
 {
     protected Sql92 $platform;
@@ -109,33 +108,4 @@ public function testGetIdentifierSeparator(): void
         self::assertEquals('.', $this->platform->getIdentifierSeparator());
     }
 
-    public function testQuoteIdentifierInFragment(): void
-    {
-        self::assertEquals('"foo"."bar"', $this->platform->quoteIdentifierInFragment('foo.bar'));
-        self::assertEquals('"foo" as "bar"', $this->platform->quoteIdentifierInFragment('foo as bar'));
-
-        // single char words
-        self::assertEquals(
-            '("foo"."bar" = "boo"."baz")',
-            $this->platform->quoteIdentifierInFragment('(foo.bar = boo.baz)', ['(', ')', '='])
-        );
-
-        // case insensitive safe words
-        self::assertEquals(
-            '("foo"."bar" = "boo"."baz") AND ("foo"."baz" = "boo"."baz")',
-            $this->platform->quoteIdentifierInFragment(
-                '(foo.bar = boo.baz) AND (foo.baz = boo.baz)',
-                ['(', ')', '=', 'and']
-            )
-        );
-
-        // case insensitive safe words in field
-        self::assertEquals(
-            '("foo"."bar" = "boo".baz) AND ("foo".baz = "boo".baz)',
-            $this->platform->quoteIdentifierInFragment(
-                '(foo.bar = boo.baz) AND (foo.baz = boo.baz)',
-                ['(', ')', '=', 'and', 'bAz']
-            )
-        );
-    }
 }