Prepare-based SQL decoration, simplify Platform to abstract registry

Replace PlatformDecoratorInterface wrapping model with SqlDecoratorInterface
prepare-based model: decorators mutate SQL objects via public API before
the standard rendering pipeline runs unchanged.

Platform becomes AbstractPlatform — a flat decorator registry without
platform-name keying or adapter resolution. Sql92Platform is the concrete
implementation. SqlProcessor gains prepare() which runs decorator then
built-in Table::prepare(). Sql::prepareStatementForSqlObject() calls
buildSqlString() directly, absorbing ParameterContainer setup.

Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>

Author: simon-mundy

src/Adapter/Platform/PlatformInterface.php

@@ -4,7 +4,7 @@
 
 namespace PhpDb\Adapter\Platform;
 
-use PhpDb\Sql\Platform\PlatformDecoratorInterface;
+use PhpDb\Sql\Platform\AbstractPlatform as SqlPlatform;
 
 interface PlatformInterface
 {
@@ -14,12 +14,9 @@ interface PlatformInterface
     public function getName(): string;
 
     /**
-     * Get Sql platform decorator
-     *
-     * Returns a PhpDb\Sql\Platform\* instance
-     * PhpDb\Sql\Platform\AbstractPlatform implements this interface
+     * Get Sql platform decorator registry
      */
-    public function getSqlPlatformDecorator(): PlatformDecoratorInterface;
+    public function getSqlPlatformDecorator(): SqlPlatform;
 
     /**
      * Get quote identifier symbol

src/Adapter/Platform/Sql92.php

@@ -6,8 +6,8 @@
 
 use Override;
 use PhpDb\Adapter\Exception\VunerablePlatformQuoteException;
-use PhpDb\Sql\Platform\Platform;
-use PhpDb\Sql\Platform\PlatformDecoratorInterface;
+use PhpDb\Sql\Platform\AbstractPlatform as SqlPlatform;
+use PhpDb\Sql\Platform\Sql92Platform;
 
 use function addcslashes;
 
@@ -43,8 +43,8 @@ public function quoteValue(string $value): string
      * {@inheritDoc}
      */
     #[Override]
-    public function getSqlPlatformDecorator(): PlatformDecoratorInterface
+    public function getSqlPlatformDecorator(): SqlPlatform
     {
-        return new Platform($this);
+        return new Sql92Platform();
     }
 }

src/Sql/AbstractSql.php

@@ -9,7 +9,7 @@
 use PhpDb\Adapter\ParameterContainer;
 use PhpDb\Adapter\Platform\PlatformInterface;
 use PhpDb\Adapter\Platform\Sql92 as DefaultAdapterPlatform;
-use PhpDb\Sql\Platform\PlatformDecoratorInterface;
+use PhpDb\Sql\Platform\AbstractPlatform as SqlPlatform;
 
 abstract class AbstractSql implements SqlInterface
 {
@@ -35,7 +35,7 @@ public function buildSqlString(
         PlatformInterface $platform,
         ?DriverInterface $driver = null,
         ?ParameterContainer $parameterContainer = null,
-        ?PlatformDecoratorInterface $decorator = null,
+        ?SqlPlatform $sqlPlatform = null,
     ): string {
         return '';
     }

src/Sql/Combine.php

@@ -9,7 +9,7 @@
 use PhpDb\Adapter\ParameterContainer;
 use PhpDb\Adapter\Platform\PlatformInterface;
 use PhpDb\Sql\Part\SqlProcessor;
-use PhpDb\Sql\Platform\PlatformDecoratorInterface;
+use PhpDb\Sql\Platform\AbstractPlatform as SqlPlatform;
 
 use function array_key_exists;
 use function array_keys;
@@ -108,13 +108,13 @@ public function buildSqlString(
         PlatformInterface $platform,
         ?DriverInterface $driver = null,
         ?ParameterContainer $parameterContainer = null,
-        ?PlatformDecoratorInterface $decorator = null,
+        ?SqlPlatform $sqlPlatform = null,
     ): string {
         if (! $this->combine) {
             return '';
         }
 
-        $processor = new SqlProcessor($platform, $driver, $parameterContainer, $decorator);
+        $processor = new SqlProcessor($platform, $driver, $parameterContainer, $sqlPlatform);
         $processor->setParamPrefix($this->processInfo['paramPrefix']);
 
         $parts = [];

src/Sql/Ddl/AlterTable.php

@@ -8,7 +8,7 @@
 use PhpDb\Adapter\ParameterContainer;
 use PhpDb\Adapter\Platform\PlatformInterface;
 use PhpDb\Sql\Part\SqlProcessor;
-use PhpDb\Sql\Platform\PlatformDecoratorInterface;
+use PhpDb\Sql\Platform\AbstractPlatform as SqlPlatform;
 use PhpDb\Sql\TableIdentifier;
 
 use function array_key_exists;
@@ -123,9 +123,9 @@ public function buildSqlString(
         PlatformInterface $platform,
         ?DriverInterface $driver = null,
         ?ParameterContainer $parameterContainer = null,
-        ?PlatformDecoratorInterface $decorator = null,
+        ?SqlPlatform $sqlPlatform = null,
     ): string {
-        $processor = new SqlProcessor($platform, $driver, $parameterContainer, $decorator);
+        $processor = new SqlProcessor($platform, $driver, $parameterContainer, $sqlPlatform);
         $processor->setParamPrefix($this->processInfo['paramPrefix']);
 
         $sql = "ALTER TABLE " . $processor->resolveTable($this->table) . "\n";

src/Sql/Ddl/CreateTable.php

@@ -8,7 +8,7 @@
 use PhpDb\Adapter\ParameterContainer;
 use PhpDb\Adapter\Platform\PlatformInterface;
 use PhpDb\Sql\Part\SqlProcessor;
-use PhpDb\Sql\Platform\PlatformDecoratorInterface;
+use PhpDb\Sql\Platform\AbstractPlatform as SqlPlatform;
 use PhpDb\Sql\TableIdentifier;
 
 use function array_key_exists;
@@ -84,9 +84,9 @@ public function buildSqlString(
         PlatformInterface $platform,
         ?DriverInterface $driver = null,
         ?ParameterContainer $parameterContainer = null,
-        ?PlatformDecoratorInterface $decorator = null,
+        ?SqlPlatform $sqlPlatform = null,
     ): string {
-        $processor = new SqlProcessor($platform, $driver, $parameterContainer, $decorator);
+        $processor = new SqlProcessor($platform, $driver, $parameterContainer, $sqlPlatform);
         $processor->setParamPrefix($this->processInfo['paramPrefix']);
 
         // CREATE [TEMPORARY] TABLE "name" (

src/Sql/Ddl/DropTable.php

@@ -8,7 +8,7 @@
 use PhpDb\Adapter\ParameterContainer;
 use PhpDb\Adapter\Platform\PlatformInterface;
 use PhpDb\Sql\Part\SqlProcessor;
-use PhpDb\Sql\Platform\PlatformDecoratorInterface;
+use PhpDb\Sql\Platform\AbstractPlatform as SqlPlatform;
 use PhpDb\Sql\TableIdentifier;
 
 class DropTable extends AbstractDdl
@@ -26,9 +26,9 @@ public function buildSqlString(
         PlatformInterface $platform,
         ?DriverInterface $driver = null,
         ?ParameterContainer $parameterContainer = null,
-        ?PlatformDecoratorInterface $decorator = null,
+        ?SqlPlatform $sqlPlatform = null,
     ): string {
-        $processor = new SqlProcessor($platform, $driver, $parameterContainer, $decorator);
+        $processor = new SqlProcessor($platform, $driver, $parameterContainer, $sqlPlatform);
 
         return 'DROP TABLE ' . $processor->resolveTable($this->table);
     }

src/Sql/Delete.php

@@ -12,7 +12,7 @@
 use PhpDb\Sql\Part\SqlProcessor;
 use PhpDb\Sql\Part\From;
 use PhpDb\Sql\Part\Where as WherePart;
-use PhpDb\Sql\Platform\PlatformDecoratorInterface;
+use PhpDb\Sql\Platform\AbstractPlatform as SqlPlatform;
 use PhpDb\Sql\Predicate\PredicateInterface;
 
 use function array_key_exists;
@@ -84,10 +84,11 @@ public function buildSqlString(
         PlatformInterface $platform,
         ?DriverInterface $driver = null,
         ?ParameterContainer $parameterContainer = null,
-        ?PlatformDecoratorInterface $decorator = null,
+        ?SqlPlatform $sqlPlatform = null,
     ): string {
-        $processor = new SqlProcessor($platform, $driver, $parameterContainer, $decorator);
+        $processor = new SqlProcessor($platform, $driver, $parameterContainer, $sqlPlatform);
         $processor->setParamPrefix($this->processInfo['paramPrefix']);
+        $processor->prepare($this);
 
         return (string) SqlFragment::of($this->getStatementKeyword())
             ->part($this->table->toSql($processor))

src/Sql/Insert.php

@@ -10,7 +10,7 @@
 use PhpDb\Adapter\Platform\PlatformInterface;
 use PhpDb\Sql\Part\SqlProcessor;
 use PhpDb\Sql\Part\From;
-use PhpDb\Sql\Platform\PlatformDecoratorInterface;
+use PhpDb\Sql\Platform\AbstractPlatform as SqlPlatform;
 
 use function array_flip;
 use function array_key_exists;
@@ -152,9 +152,9 @@ public function buildSqlString(
         PlatformInterface $platform,
         ?DriverInterface $driver = null,
         ?ParameterContainer $parameterContainer = null,
-        ?PlatformDecoratorInterface $decorator = null,
+        ?SqlPlatform $sqlPlatform = null,
     ): string {
-        $processor = new SqlProcessor($platform, $driver, $parameterContainer, $decorator);
+        $processor = new SqlProcessor($platform, $driver, $parameterContainer, $sqlPlatform);
         $processor->setParamPrefix($this->processInfo['paramPrefix']);
 
         $keyword  = $this->getStatementKeyword();

src/Sql/Part/SqlProcessor.php

@@ -10,7 +10,7 @@
 use PhpDb\Sql\Argument\Parameter;
 use PhpDb\Sql\ArgumentInterface;
 use PhpDb\Sql\ExpressionInterface;
-use PhpDb\Sql\Platform\PlatformDecoratorInterface;
+use PhpDb\Sql\Platform\AbstractPlatform as SqlPlatform;
 use PhpDb\Sql\Select;
 use PhpDb\Sql\TableIdentifier;
 
@@ -33,7 +33,7 @@ public function __construct(
         public readonly PlatformInterface $platform,
         public readonly ?DriverInterface $driver = null,
         public readonly ?ParameterContainer $parameterContainer = null,
-        private ?PlatformDecoratorInterface $decorator = null,
+        private ?SqlPlatform $sqlPlatform = null,
     ) {
         $this->identifierSeparator = $platform->getIdentifierSeparator();
     }
@@ -48,6 +48,15 @@ public function setParamPrefix(string $prefix): void
         $this->paramPrefix = $prefix;
     }
 
+    public function prepare(object $subject): void
+    {
+        $this->sqlPlatform?->getTypeDecorator($subject)?->prepare($subject, $this);
+
+        if ($subject instanceof Select) {
+            $subject->tablePart()->prepare($this);
+        }
+    }
+
     public function renderParameter(Parameter $param, ?string $nameOverride = null): string
     {
         if ($this->parameterContainer instanceof ParameterContainer) {
@@ -62,12 +71,6 @@ public function renderParameter(Parameter $param, ?string $nameOverride = null):
 
     public function processSubSelect(Select $subselect): string
     {
-        $decorator = null;
-        if ($this->decorator !== null) {
-            $decorator = clone $this->decorator;
-            $decorator->setSubject($subselect);
-        }
-
         if ($this->parameterContainer instanceof ParameterContainer) {
             $this->subselectCount++;
             $subselect->processInfo['subselectCount'] = $this->subselectCount;
@@ -78,7 +81,7 @@ public function processSubSelect(Select $subselect): string
                 $this->platform,
                 $this->driver,
                 $this->parameterContainer,
-                $decorator,
+                $this->sqlPlatform,
             );
             $this->subselectCount = $subselect->processInfo['subselectCount'];
 
@@ -89,7 +92,7 @@ public function processSubSelect(Select $subselect): string
             $this->platform,
             $this->driver,
             $this->parameterContainer,
-            $decorator,
+            $this->sqlPlatform,
         );
     }