Make Table properties public, remove accessor methods

Expose From, Columns, and Join as public properties on Table,
eliminating three method calls per buildSqlString invocation.

Author: simon-mundy

src/Sql/Part/Table.php

@@ -21,9 +21,9 @@
 
 class Table
 {
-    private From $from;
-    private Columns $columns;
-    private ?Join $join = null;
+    public From $from;
+    public Columns $columns;
+    public ?Join $join = null;
 
     public function __construct()
     {
@@ -144,21 +144,6 @@ public function resetJoins(): static
         return $this;
     }
 
-    public function from(): From
-    {
-        return $this->from;
-    }
-
-    public function columns(): Columns
-    {
-        return $this->columns;
-    }
-
-    public function joins(): ?Join
-    {
-        return $this->join;
-    }
-
     public function __clone()
     {
         $this->from    = clone $this->from;

src/Sql/Select.php

@@ -350,7 +350,7 @@ public function getRawState(?string $key = null): mixed
             self::TABLE      => $this->table->getFrom(),
             self::QUANTIFIER => $this->quantifier?->get(),
             self::COLUMNS    => $this->table->getColumns(),
-            self::JOINS      => $this->table->joins() ?? new Join(),
+            self::JOINS      => $this->table->join ?? new Join(),
             self::WHERE      => $this->where  ??= new Where(),
             self::ORDER      => $this->orderBy?->get() ?? [],
             self::GROUP      => $this->groupBy?->get() ?? [],
@@ -380,12 +380,13 @@ public function buildSqlString(AbstractSqlRenderer $renderer): string
     {
         $renderer->getTypeDecorator($this)?->prepare($this, $renderer);
 
+        $combine = $this->combine?->toSql($renderer);
+
         $sql = implode(' ', array_filter([
-            'SELECT',
             $this->quantifier?->toSql($renderer),
-            $this->table->columns()->toSql($renderer),
-            $this->table->from()->toSql($renderer),
-            $this->table->joins()?->toSql($renderer),
+            $this->table->columns->toSql($renderer),
+            $this->table->from->toSql($renderer),
+            $this->table->join?->toSql($renderer),
             $this->where?->toSql($renderer),
             $this->groupBy?->toSql($renderer),
             $this->having?->toSql($renderer),
@@ -394,9 +395,9 @@ public function buildSqlString(AbstractSqlRenderer $renderer): string
             $this->offset?->toSql($renderer),
         ]));
 
-        $combine = $this->combine?->toSql($renderer);
-
-        return $combine !== null ? "( $sql ) $combine" : $sql;
+        return $combine !== null
+            ? "( SELECT $sql ) $combine"
+            : "SELECT $sql";
     }
 
     /**
@@ -412,7 +413,7 @@ public function __get(string $name): Where|Join|Having
             case 'having':
                 return $this->having ??= new Having();
             case 'joins':
-                return $this->table->joins() ?? new Join();
+                return $this->table->join ?? new Join();
             default:
                 throw new Exception\InvalidArgumentException('Not a valid magic property for this object');
         }