Add renderer-level identifier cache to avoid cross-object method calls

Cache quoted identifiers on AbstractSqlRenderer as a public array,
letting all hot-path callers use a simple array lookup instead of
dispatching through $platform->quoteIdentifier() on every access.

Author: simon-mundy

src/Sql/Insert.php

@@ -158,7 +158,7 @@ public function buildSqlString(AbstractSqlRenderer $renderer): string
             if ($columnNames !== []) {
                 $columns = [];
                 foreach ($columnNames as $col) {
-                    $columns[] = $renderer->platform->quoteIdentifier($col);
+                    $columns[] = $renderer->identifier[$col] ??= $renderer->platform->quoteIdentifier($col);
                 }
                 return $keyword . ' ' . $tableSql
                     . ' (' . implode(', ', $columns) . ') ' . $selectSql;
@@ -178,7 +178,7 @@ public function buildSqlString(AbstractSqlRenderer $renderer): string
         $hasParamContainer = $renderer->parameterContainer instanceof ParameterContainer;
 
         foreach ($this->columns as $column => $value) {
-            $columns[] = $renderer->platform->quoteIdentifier($column);
+            $columns[] = $renderer->identifier[$column] ??= $renderer->platform->quoteIdentifier($column);
 
             if ($value === null) {
                 $values[] = 'NULL';

src/Sql/Part/Columns.php

@@ -61,15 +61,19 @@ public function toSql(AbstractSqlRenderer $renderer, string $paramPrefix = '', i
             $column = $ref->column;
 
             if ($column instanceof Identifier) {
-                $columnSql = $prefix . $platform->quoteIdentifier($column->identifier);
+                $columnSql = $prefix
+                    . ($renderer->identifier[$column->identifier]
+                        ??= $platform->quoteIdentifier($column->identifier));
             } elseif ($column instanceof ArgumentInterface) {
                 $columnSql = $prefix . $renderer->renderArgument($column, '', $pi);
             } else {
                 $columnSql = $renderer->render($column, $ref->columnAlias ?? 'column');
             }
 
             if ($ref->columnAlias !== null) {
-                $fragments[] = $columnSql . ' AS ' . $platform->quoteIdentifier($ref->columnAlias);
+                $fragments[] = $columnSql . ' AS '
+                    . ($renderer->identifier[$ref->columnAlias]
+                        ??= $platform->quoteIdentifier($ref->columnAlias));
             } elseif ($ref->containsAlias) {
                 $fragments[] = $columnSql;
             } else {

src/Sql/Part/GroupBy.php

@@ -29,7 +29,8 @@ public function toSql(AbstractSqlRenderer $renderer, string $paramPrefix = '', i
             $column = $ref->column;
 
             if ($column instanceof Identifier) {
-                $groups[] = $platform->quoteIdentifier($column->identifier);
+                $id       = $column->identifier;
+                $groups[] = $renderer->identifier[$id] ??= $platform->quoteIdentifier($id);
             } elseif ($column instanceof ArgumentInterface) {
                 $pi       = 0;
                 $groups[] = $renderer->renderArgument($column, '', $pi);

src/Sql/Part/InsertSelect.php

@@ -34,7 +34,7 @@ public function toSql(AbstractSqlRenderer $renderer, string $paramPrefix = '', i
 
         $columns = [];
         foreach (array_keys($this->columns) as $name) {
-            $columns[] = $renderer->platform->quoteIdentifier($name);
+            $columns[] = $renderer->identifier[$name] ??= $renderer->platform->quoteIdentifier($name);
         }
         $columnsSql = implode(', ', $columns);
 

src/Sql/Part/InsertValues.php

@@ -48,7 +48,7 @@ public function toSql(AbstractSqlRenderer $renderer, string $paramPrefix = '', i
         $isPdoDriver = $renderer->driver instanceof PdoDriverInterface;
 
         foreach ($this->columnValues as $cv) {
-            $columns[] = $renderer->platform->quoteIdentifier($cv->column);
+            $columns[] = $renderer->identifier[$cv->column] ??= $renderer->platform->quoteIdentifier($cv->column);
 
             $values[] = match ($cv->value->getType()) {
                 ArgumentType::Parameter => $renderer->bindParameter(

src/Sql/Part/OrderBy.php

@@ -37,8 +37,9 @@ public function toSql(AbstractSqlRenderer $renderer, string $paramPrefix = '', i
             $column = $spec->column;
 
             if ($column instanceof Identifier) {
-                $orders[] = $platform->quoteIdentifier($column->identifier)
-                           . ' ' . $spec->direction;
+                $orders[] = ($renderer->identifier[$column->identifier]
+                    ??= $platform->quoteIdentifier($column->identifier))
+                    . ' ' . $spec->direction;
             } elseif ($column instanceof ArgumentInterface) {
                 $pi       = 0;
                 $orders[] = $renderer->renderArgument($column, '', $pi)

src/Sql/Part/Set.php

@@ -39,7 +39,8 @@ public function toSql(AbstractSqlRenderer $renderer, string $paramPrefix = '', i
         $isPdoDriver = $renderer->driver instanceof PdoDriverInterface;
 
         foreach ($this->model as $column => $arg) {
-            $prefix = $renderer->platform->quoteIdentifier($this->columnIds[$column]->identifier) . ' = ';
+            $id     = $this->columnIds[$column]->identifier;
+            $prefix = ($renderer->identifier[$id] ??= $renderer->platform->quoteIdentifier($id)) . ' = ';
 
             $setSql[] = $prefix . match ($arg->getType()) {
                 ArgumentType::Parameter => $renderer->bindParameter(

src/Sql/Platform/AbstractSqlRenderer.php

@@ -46,6 +46,9 @@ abstract class AbstractSqlRenderer
 
     private string $identifierSeparator = '.';
 
+    /** @var array<string, string> */
+    public array $identifier = [];
+
     /** @var array<int, string> */
     private array $tablePrefixCache = [];
 
@@ -67,6 +70,7 @@ public function init(
             $this->platform            = $platform;
             $this->identifierSeparator = $platform->getIdentifierSeparator();
             $this->tablePrefixCache    = [];
+            $this->identifier          = [];
         }
 
         $this->driver                 = $driver;
@@ -120,14 +124,14 @@ public function renderTableSource(
         } elseif ($table instanceof Select) {
             $rendered = '(' . $this->processSubSelect($table) . ')';
         } elseif (is_string($table)) {
-            $rendered = $this->platform->quoteIdentifier($table);
+            $rendered = $this->identifier[$table] ??= $this->platform->quoteIdentifier($table);
         } else {
             $pi       = 0;
             $rendered = $table->toSql($this, '', $pi);
         }
 
         if ($alias !== null) {
-            $rendered .= ' AS ' . $this->platform->quoteIdentifier($alias);
+            $rendered .= ' AS ' . ($this->identifier[$alias] ??= $this->platform->quoteIdentifier($alias));
         }
 
         return $rendered;
@@ -143,10 +147,10 @@ public function renderResolvedTable(
 
         if ($table instanceof TableIdentifier) {
             $prefix = $alias !== null
-                ? $this->platform->quoteIdentifier($alias)
+                ? ($this->identifier[$alias] ??= $this->platform->quoteIdentifier($alias))
                 : $this->platform->quoteIdentifier(name: $table->table, prefix: $table->schema);
         } else {
-            $prefix = $this->platform->quoteIdentifier($alias);
+            $prefix = $this->identifier[$alias] ??= $this->platform->quoteIdentifier($alias);
         }
 
         return $this->tablePrefixCache[$id] = $prefix . $this->identifierSeparator;
@@ -158,7 +162,8 @@ public function renderIdentifiersIn(string $part): string
         $count       = count($identifiers);
 
         for ($idx = 1; $idx < $count; $idx += 2) {
-            $identifiers[$idx] = $this->platform->quoteIdentifier($identifiers[$idx]);
+            $id                = $identifiers[$idx];
+            $identifiers[$idx] = $this->identifier[$id] ??= $this->platform->quoteIdentifier($id);
         }
 
         return implode('', $identifiers);
@@ -184,7 +189,8 @@ public function renderArgument(
         int &$paramIndex,
     ): string {
         return match (true) {
-            $argument instanceof Identifier    => $this->platform->quoteIdentifier($argument->identifier),
+            $argument instanceof Identifier    => $this->identifier[$argument->identifier]
+                ??= $this->platform->quoteIdentifier($argument->identifier),
             $argument instanceof Literal       => $argument->literal,
             $argument instanceof NullValue     => 'NULL',
             $argument instanceof Parameter     => $this->bindParameter($argument),
@@ -245,7 +251,8 @@ private function renderIdentifiers(array $identifiers): string
     {
         $quoted = [];
         foreach ($identifiers as $id) {
-            $quoted[] = $this->platform->quoteIdentifier($id->identifier);
+            $name     = $id->identifier;
+            $quoted[] = $this->identifier[$name] ??= $this->platform->quoteIdentifier($name);
         }
         return implode(', ', $quoted);
     }