Merge SqlProcessor into AbstractSqlRenderer, eliminating unnecessary abstraction

SqlProcessor (per-call rendering context) and AbstractPlatform (persistent
decorator registry) were two halves of the same concern. Merging them into
AbstractSqlRenderer gives the decorator system direct access to the rendering
engine and removes the processInfo communication channel between statement
objects and the processor.

- AbstractPlatform + SqlProcessor → AbstractSqlRenderer (abstract)
- Sql92Platform → Sql92Renderer (concrete)
- buildSqlString() now takes a single AbstractSqlRenderer param
- Eliminated $processInfo; paramPrefix/subselectCount managed by renderer
- Method renames: renderExpression→render, renderParameter→bindParameter,
  renderQuotedIdentifiers→quoteIdentifiersIn, getQuotedPrefix→tablePrefix
- resolveTableWithAlias merged into resolveTable(withAlias: true)

Author: simon-mundy

src/Adapter/Platform/PlatformInterface.php

@@ -4,7 +4,7 @@
 
 namespace PhpDb\Adapter\Platform;
 
-use PhpDb\Sql\Platform\AbstractPlatform as SqlPlatform;
+use PhpDb\Sql\Platform\AbstractSqlRenderer;
 
 interface PlatformInterface
 {
@@ -16,7 +16,7 @@ public function getName(): string;
     /**
      * Get Sql platform decorator registry
      */
-    public function getSqlPlatformDecorator(): SqlPlatform;
+    public function getSqlPlatformDecorator(): AbstractSqlRenderer;
 
     /**
      * Get quote identifier symbol

src/Adapter/Platform/Sql92.php

@@ -6,8 +6,8 @@
 
 use Override;
 use PhpDb\Adapter\Exception\VunerablePlatformQuoteException;
-use PhpDb\Sql\Platform\AbstractPlatform as SqlPlatform;
-use PhpDb\Sql\Platform\Sql92Platform;
+use PhpDb\Sql\Platform\AbstractSqlRenderer;
+use PhpDb\Sql\Platform\Sql92Renderer;
 
 use function addcslashes;
 
@@ -41,8 +41,8 @@ public function quoteValue(string $value): string
     /**
      * {@inheritDoc}
      */
-    public function getSqlPlatformDecorator(): SqlPlatform
+    public function getSqlPlatformDecorator(): AbstractSqlRenderer
     {
-        return new Sql92Platform();
+        return new Sql92Renderer();
     }
 }

src/Sql/AbstractPreparableSql.php

@@ -8,6 +8,7 @@
 use PhpDb\Adapter\AdapterInterface;
 use PhpDb\Adapter\ParameterContainer;
 use PhpDb\Adapter\StatementContainerInterface;
+use PhpDb\Sql\Platform\Sql92Renderer;
 
 abstract class AbstractPreparableSql extends AbstractSql implements PreparableSqlInterface
 {
@@ -25,7 +26,9 @@ public function prepareStatement(
         }
 
         $statementContainer->setSql(
-            $this->buildSqlString($adapter->getPlatform(), $adapter->getDriver(), $parameterContainer)
+            $this->buildSqlString(
+                (new Sql92Renderer())->init($adapter->getPlatform(), $adapter->getDriver(), $parameterContainer)
+            )
         );
 
         return $statementContainer;

src/Sql/AbstractSql.php

@@ -5,38 +5,26 @@
 namespace PhpDb\Sql;
 
 use Override;
-use PhpDb\Adapter\Driver\DriverInterface;
-use PhpDb\Adapter\ParameterContainer;
 use PhpDb\Adapter\Platform\PlatformInterface;
 use PhpDb\Adapter\Platform\Sql92 as DefaultAdapterPlatform;
-use PhpDb\Sql\Platform\AbstractPlatform as SqlPlatform;
+use PhpDb\Sql\Platform\AbstractSqlRenderer;
+use PhpDb\Sql\Platform\Sql92Renderer;
 
 abstract class AbstractSql implements SqlInterface
 {
-    /**
-     * Information used during processing
-     *
-     * @var array{paramPrefix: string, subselectCount: int}
-     */
-    public array $processInfo = ['paramPrefix' => '', 'subselectCount' => 0];
-
     /**
      * {@inheritDoc}
      */
     #[Override]
     public function getSqlString(?PlatformInterface $adapterPlatform = null): string
     {
-        $adapterPlatform = $adapterPlatform ?: new DefaultAdapterPlatform();
-
-        return $this->buildSqlString($adapterPlatform);
+        return $this->buildSqlString(
+            (new Sql92Renderer())->init($adapterPlatform ?? new DefaultAdapterPlatform())
+        );
     }
 
-    public function buildSqlString(
-        PlatformInterface $platform,
-        ?DriverInterface $driver = null,
-        ?ParameterContainer $parameterContainer = null,
-        ?SqlPlatform $sqlPlatform = null,
-    ): string {
+    public function buildSqlString(AbstractSqlRenderer $renderer): string
+    {
         return '';
     }
 }

src/Sql/Argument/Identifier.php

@@ -6,7 +6,7 @@
 
 use PhpDb\Sql\ArgumentInterface;
 use PhpDb\Sql\ArgumentType;
-use PhpDb\Sql\Part\SqlProcessor;
+use PhpDb\Sql\Platform\AbstractSqlRenderer;
 
 final readonly class Identifier implements ArgumentInterface
 {
@@ -25,8 +25,8 @@ public function getValue(): string
         return $this->identifier;
     }
 
-    public function render(SqlProcessor $processor, string $paramPrefix, int &$paramIndex): string
+    public function render(AbstractSqlRenderer $renderer, string $paramPrefix, int &$paramIndex): string
     {
-        return $processor->platform->quoteIdentifier($this->identifier);
+        return $renderer->platform->quoteIdentifier($this->identifier);
     }
 }

src/Sql/Argument/Identifiers.php

@@ -6,7 +6,7 @@
 
 use PhpDb\Sql\ArgumentInterface;
 use PhpDb\Sql\ArgumentType;
-use PhpDb\Sql\Part\SqlProcessor;
+use PhpDb\Sql\Platform\AbstractSqlRenderer;
 
 use function implode;
 
@@ -44,11 +44,11 @@ public function getValue(): array
         return $result;
     }
 
-    public function render(SqlProcessor $processor, string $paramPrefix, int &$paramIndex): string
+    public function render(AbstractSqlRenderer $renderer, string $paramPrefix, int &$paramIndex): string
     {
         $quoted = [];
         foreach ($this->identifiers as $identifier) {
-            $quoted[] = $identifier->render($processor, $paramPrefix, $paramIndex);
+            $quoted[] = $identifier->render($renderer, $paramPrefix, $paramIndex);
         }
         return implode(', ', $quoted);
     }

src/Sql/Argument/Literal.php

@@ -6,7 +6,7 @@
 
 use PhpDb\Sql\ArgumentInterface;
 use PhpDb\Sql\ArgumentType;
-use PhpDb\Sql\Part\SqlProcessor;
+use PhpDb\Sql\Platform\AbstractSqlRenderer;
 
 final readonly class Literal implements ArgumentInterface
 {
@@ -25,7 +25,7 @@ public function getValue(): string
         return $this->literal;
     }
 
-    public function render(SqlProcessor $processor, string $paramPrefix, int &$paramIndex): string
+    public function render(AbstractSqlRenderer $renderer, string $paramPrefix, int &$paramIndex): string
     {
         return $this->literal;
     }

src/Sql/Argument/NullValue.php

@@ -6,7 +6,7 @@
 
 use PhpDb\Sql\ArgumentInterface;
 use PhpDb\Sql\ArgumentType;
-use PhpDb\Sql\Part\SqlProcessor;
+use PhpDb\Sql\Platform\AbstractSqlRenderer;
 
 final readonly class NullValue implements ArgumentInterface
 {
@@ -20,7 +20,7 @@ public function getValue(): null
         return null;
     }
 
-    public function render(SqlProcessor $processor, string $paramPrefix, int &$paramIndex): string
+    public function render(AbstractSqlRenderer $renderer, string $paramPrefix, int &$paramIndex): string
     {
         return 'NULL';
     }

src/Sql/Argument/Parameter.php

@@ -6,7 +6,7 @@
 
 use PhpDb\Sql\ArgumentInterface;
 use PhpDb\Sql\ArgumentType;
-use PhpDb\Sql\Part\SqlProcessor;
+use PhpDb\Sql\Platform\AbstractSqlRenderer;
 
 final readonly class Parameter implements ArgumentInterface
 {
@@ -42,8 +42,8 @@ public function getTypeHint(): ?string
         return $this->typeHint;
     }
 
-    public function render(SqlProcessor $processor, string $paramPrefix, int &$paramIndex): string
+    public function render(AbstractSqlRenderer $renderer, string $paramPrefix, int &$paramIndex): string
     {
-        return $processor->renderParameter($this);
+        return $renderer->bindParameter($this);
     }
 }

src/Sql/Argument/Select.php

@@ -7,7 +7,7 @@
 use PhpDb\Sql\ArgumentInterface;
 use PhpDb\Sql\ArgumentType;
 use PhpDb\Sql\ExpressionInterface;
-use PhpDb\Sql\Part\SqlProcessor;
+use PhpDb\Sql\Platform\AbstractSqlRenderer;
 use PhpDb\Sql\SqlInterface;
 
 final readonly class Select implements ArgumentInterface
@@ -27,12 +27,12 @@ public function getValue(): ExpressionInterface|SqlInterface
         return $this->select;
     }
 
-    public function render(SqlProcessor $processor, string $paramPrefix, int &$paramIndex): string
+    public function render(AbstractSqlRenderer $renderer, string $paramPrefix, int &$paramIndex): string
     {
         if ($this->select instanceof \PhpDb\Sql\Select) {
-            return '(' . $processor->processSubSelect($this->select) . ')';
+            return '(' . $renderer->processSubSelect($this->select) . ')';
         }
 
-        return $this->select->toSql($processor, $paramPrefix, $paramIndex);
+        return $this->select->toSql($renderer, $paramPrefix, $paramIndex);
     }
 }