Skip to content

Mktmpdir support #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Mktmpdir support #48

wants to merge 5 commits into from

Conversation

@djberg96
Copy link
Contributor

@djberg96 djberg96 commented Oct 3, 2025

This PR adds a mktmpdir method along with corresponding tests.

There is also an update to the glob method to support options. Without this change I get:

memfs/lib/memfs/dir.rb:66:in `block (2 levels) in glob': undefined method `|' for an instance of Hash (NoMethodError)
  File.fnmatch?(pattern, path, flags | GLOB_FLAGS)
  from /Users/dberger/Dev/memfs/lib/memfs/dir.rb:65:in `any?'
  from /Users/dberger/Dev/memfs/lib/memfs/dir.rb:65:in `block in glob'
  from /Users/dberger/Dev/memfs/lib/memfs/dir.rb:64:in `select'
  from /Users/dberger/Dev/memfs/lib/memfs/dir.rb:64:in `glob'

Addresses #36

Mostly written by Claude 4.5.

djberg96
djberg96 commented Oct 4, 2025
View reviewed changes
.github/workflows/ci.yml
fail-fast: false
matrix:
ruby-version: ['3.2', '3.1', '3.0', '2.7', '2.6']
ruby-version: ['3.4', '3.3', '3.2', '3.1', '3.0', '2.7']
Copy link
Contributor Author

@djberg96 djberg96 Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up making a separate PR for this stuff: #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@djberg96