Fix types for PRState constant

simondanielsson · simondanielsson · commit 0e18fc16aa79 · 2024-09-23T22:20:48.000+02:00
diff --git a/cmd/internal/services/reviews_services.go b/cmd/internal/services/reviews_services.go
@@ -139,7 +139,7 @@ func (rs *ReviewsService) RefreshPullRequests(ctx context.Context, tx *gorm.DB,
 	// find PRs that are no longer open
 	var closedPRs []*models.PullRequest
 	for _, existingPR := range existingPRs {
-		if existingPR.State == constants.PRStateClosed {
+		if existingPR.State == string(constants.PRStateClosed) {
 			continue
 		}
 		found := false
@@ -150,7 +150,7 @@ func (rs *ReviewsService) RefreshPullRequests(ctx context.Context, tx *gorm.DB,
 			}
 		}
 		if !found {
-			existingPR.State = constants.PRStateClosed
+			existingPR.State = string(constants.PRStateClosed)
 			closedPRs = append(closedPRs, existingPR)
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ func (rs ReviewsService) RefreshPullRequests(ctx context.Context, tx gorm.DB,`
`139`	`139`	`// find PRs that are no longer open`
`140`	`140`	`var closedPRs []*models.PullRequest`
`141`	`141`	`for _, existingPR := range existingPRs {`
`142`		`- if existingPR.State == constants.PRStateClosed {`
	`142`	`+ if existingPR.State == string(constants.PRStateClosed) {`
`143`	`143`	`continue`
`144`	`144`	`}`
`145`	`145`	`found := false`
`@@ -150,7 +150,7 @@ func (rs ReviewsService) RefreshPullRequests(ctx context.Context, tx gorm.DB,`
`150`	`150`	`}`
`151`	`151`	`}`
`152`	`152`	`if !found {`
`153`		`- existingPR.State = constants.PRStateClosed`
	`153`	`+ existingPR.State = string(constants.PRStateClosed)`
`154`	`154`	`closedPRs = append(closedPRs, existingPR)`
`155`	`155`	`}`
`156`	`156`	`}`