CRC: make construct_print_transaction_event take a ref

Signed-off-by: Jacinta Ferrant <236437600+jacinta-stacks@users.noreply.github.com>

Author: jacinta-stacks

clarity/src/vm/contexts.rs

@@ -1514,13 +1514,12 @@ impl<'a, 'b, 'hooks> ExecutionState<'a, 'b, 'hooks> {
     }
 
     pub fn construct_print_transaction_event(
-        contract_id: &QualifiedContractIdentifier,
-        value: &Value,
+        contract_id: QualifiedContractIdentifier,
+        value: Value,
     ) -> StacksTransactionEvent {
         let print_event = SmartContractEventData {
-            key: (contract_id.clone(), "print".to_string()),
-            // TODO: why isn't this charged for?
-            value: value.clone(),
+            key: (contract_id, "print".to_string()),
+            value,
         };
 
         StacksTransactionEvent::SmartContractEvent(print_event)
@@ -1529,10 +1528,10 @@ impl<'a, 'b, 'hooks> ExecutionState<'a, 'b, 'hooks> {
     pub fn register_print_event(
         &mut self,
         invoke_ctx: &InvocationContext,
-        value: &Value,
+        value: Value,
     ) -> Result<(), VmExecutionError> {
         let event = Self::construct_print_transaction_event(
-            &invoke_ctx.contract_context.contract_identifier,
+            invoke_ctx.contract_context.contract_identifier.clone(),
             value,
         );
 

clarity/src/vm/functions/mod.rs

@@ -663,8 +663,9 @@ fn special_print(
         debug!("{}", input.as_ref());
     }
 
-    exec_state.register_print_event(invoke_ctx, input.as_ref())?;
-    input.clone_with_cost(exec_state)
+    let value = input.clone_with_cost(exec_state)?;
+    exec_state.register_print_event(invoke_ctx, value.clone())?;
+    Ok(value)
 }
 
 fn special_if(

pox-locking/src/pox_2.rs

@@ -514,8 +514,10 @@ pub fn handle_contract_call(
             if let Some(event_info) = event_info_opt {
                 let event_response =
                     Value::okay(event_info).expect("FATAL: failed to construct (ok event-info)");
-                let tx_event =
-                    ExecutionState::construct_print_transaction_event(contract_id, &event_response);
+                let tx_event = ExecutionState::construct_print_transaction_event(
+                    contract_id.clone(),
+                    event_response,
+                );
                 Some(tx_event)
             } else {
                 None

pox-locking/src/pox_3.rs

@@ -404,8 +404,10 @@ pub fn handle_contract_call(
             if let Some(event_info) = event_info_opt {
                 let event_response =
                     Value::okay(event_info).expect("FATAL: failed to construct (ok event-info)");
-                let tx_event =
-                    ExecutionState::construct_print_transaction_event(contract_id, &event_response);
+                let tx_event = ExecutionState::construct_print_transaction_event(
+                    contract_id.clone(),
+                    event_response,
+                );
                 Some(tx_event)
             } else {
                 None

pox-locking/src/pox_4.rs

@@ -370,8 +370,10 @@ pub fn handle_contract_call(
             if let Some(event_info) = event_info_opt {
                 let event_response =
                     Value::okay(event_info).expect("FATAL: failed to construct (ok event-info)");
-                let tx_event =
-                    ExecutionState::construct_print_transaction_event(contract_id, &event_response);
+                let tx_event = ExecutionState::construct_print_transaction_event(
+                    contract_id.clone(),
+                    event_response,
+                );
                 Some(tx_event)
             } else {
                 None

stackslib/src/chainstate/stacks/boot/mod.rs

@@ -622,7 +622,7 @@ impl StacksChainState {
 
             // Add synthetic print event for `handle-unlock`, since it alters stacking state
             let tx_event =
-                ExecutionState::construct_print_transaction_event(&pox_contract, &event_info);
+                ExecutionState::construct_print_transaction_event(pox_contract.clone(), event_info);
             events.push(tx_event);
             total_events.extend(events.into_iter());
         }