just test/functest/doctest issues

[markokocic]

I had multiple issues when trying to run just functest

1. it requires /usr/bin/time - hard to spot, because the error message is not clear, since my fish shell already have time as built-in. Figured out that I need to install time package only after switching temporarily to bash.
2. looks like there's an issue with Just syntax for functtest and perftest:

marko@host ~/s/c/hledger (just)> just functest
hledger-1.51.99: unregistering (local file changes: /home/marko/src/cvstree/hledger/.git/index)
hledger> build (lib + exe) with ghc-9.12.2
Preprocessing library for hledger-1.51.99...
Building library for hledger-1.51.99...
[ 6 of 42] Compiling Hledger.Cli.CliOptions [/home/marko/src/cvstree/hledger/.git/index changed]
[ 9 of 42] Compiling Hledger.Cli.Commands.Stats [/home/marko/src/cvstree/hledger/.git/index changed]
Preprocessing executable 'hledger' for hledger-1.51.99...
Building executable 'hledger' for hledger-1.51.99...
hledger> copy/register
Installing library in /home/marko/src/cvstree/hledger/.stack-work/install/x86_64-linux-tinfo6/4adf8bb2b6ddceca88962ce280ef3f37ec29c6c8a4e6c37418e12d788ac807ed/9.12.2/lib/x86_64-linux-ghc-9.12.2-167a/hledger-1.51.99-7LzA5FA3oRZHPpFCYRyB0k
Installing executable hledger in /home/marko/src/cvstree/hledger/.stack-work/install/x86_64-linux-tinfo6/4adf8bb2b6ddceca88962ce280ef3f37ec29c6c8a4e6c37418e12d788ac807ed/9.12.2/bin
Registering library for hledger-1.51.99...
sh: 1: Syntax error: "(" unexpected (expecting ")")
error: Recipe `functest` failed on line 486 with exit code 2
marko@host~/s/c/hledger (just) [2]> just --version
just 1.46.0
marko@host~/s/c/hledger (just)>

[simonmichael]

https://github.com/casey/just?tab=readme-ov-file#shell says just's default shell sh -cu. Is that fish on your system ?

I can run just functest and just perftest without error from osh, bash, zsh or fish shells here.

[markokocic]

My default shell is fish shell, but I also tried with bash and sh, the results are the same.
I'm running Debian stable on wsl:

marko@host~/s/c/hledger (just)> echo $SHELL
/usr/bin/fish
marko@host ~/s/c/hledger (just)> just functest
sh: 1: Syntax error: "(" unexpected (expecting ")")
error: Recipe `functest` failed on line 486 with exit code 2
marko@host ~/s/c/hledger (just) [2]> bash
marko@host:~/src/cvstree/hledger$ just functest
sh: 1: Syntax error: "(" unexpected (expecting ")")
error: Recipe `functest` failed on line 486 with exit code 2
marko@host: ~/src/cvstree/hledger$ exit
exit
marko@host ~/s/c/hledger (just) [2]> sh
$ just functest
sh: 1: Syntax error: "(" unexpected (expecting ")")
error: Recipe `functest` failed on line 486 with exit code 2
$ exit
marko@host ~/s/c/hledger (just) [2]> uname -a
Linux host 6.6.87.2-microsoft-standard-WSL2 #1 SMP PREEMPT_DYNAMIC Thu Jun  5 18:30:46 UTC 2025 x86_64 GNU/Linux
marko@host ~/s/c/hledger (just)>

[markokocic]

It looks like, even if you switch your shell by executing bash from your original shell, just still chooses sh to execute actual scripts, and it seems sh doesn't like (( syntax.

By setting #!/usr/bin/env bash at the beginning of functest command, the script was executed successfully.

My pull request should fix this. [#2527]

[markokocic]

hi @simonmichael , your fix to force bash fixed it for me, not I can execute just functest.

However, I still notice some oddities; I'm not sure if that's intentional:

Steps to reproduce:

1. run stack install to compile the whole project. ok
2. run just functest. ok
3. run just test

• 66 files recompiled. why?
• just functest --hide called internally by just
• it compiles 66 files again
• compilation fails with the following message:

hledger-lib> /home/marko/src/cvstree/hledger/hledger-lib/Hledger/Reports/ReportOptions.hs:1003:25: error: [GHC-63397] [-Wname-shadowing, Werror=name-shadowing]
hledger-lib>     This binding for ‘interval’ shadows the existing binding
hledger-lib>       defined at Hledger/Reports/ReportOptions.hs:930:1
hledger-lib>      |
hledger-lib> 1003 |                    Just interval -> ropts{interval_ = interval}
hledger-lib>      |                         ^^^^^^^^
hledger-lib>
Progress 1/2

Error: [S-7282]
       Stack failed to execute the build plan.

       While executing the build plan, Stack encountered the error:

       [S-7011]
       While building package hledger-lib-1.51.99 (scroll up to its section to see the error) using:
       /home/marko/.stack/setup-exe-cache/x86_64-linux-tinfo6/Cabal-simple_w2MFVN35_3.14.1.0_ghc-9.12.2 --verbose=1 --builddir=.stack-work/dist/x86_64-linux-tinfo6/ghc-9.12.2 build lib:hledger-lib --ghc-options ""
       Process exited with code: ExitFailure 1
error: Recipe `functest` failed on line 482 with exit code 1
error: Recipe `test` failed on line 409 with exit code 1
marko@host ~/s/c/hledger (master) [1]>

Running stack install afterwards will recompile successfully again.

So, there are two issues now:

1. just test compilation failure
2. multiple recompilations when running tests. not sure if strictly needed or not.

[simonmichael]

just test includes the doctest suite, and that requires a separate build of everything, also overwriting the regular build so that has to be rebuilt again... I don't know why and would love to see it solved. I usually run just functest instead to avoid this.

Compilation failed because I introduced a warning today, I got impatient and bypassed the full CI tests for a change that seemed good. Sorry about that, I am pushing a fix.

[markokocic]

I rearranged the test to avoid double recompilation #2532 . Now it recompiles only once