Skip to content

Commit a66db08

Browse files
committed
Add pyasyncore to mitigate removal of asyncore in PEP 594
1 parent 0add215 commit a66db08

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ The [plugins branch](https://github.com/simonrob/email-oauth2-proxy/tree/plugins
9494

9595

9696
## Potential improvements (pull requests welcome)
97-
- Switch to asyncio (asyncore is currently deprecated, but [PEP 594](https://peps.python.org/pep-0594/) will remove it completely in Python 3.12)
97+
- Switch to asyncio? (asyncore is currently deprecated, but [PEP 594](https://peps.python.org/pep-0594/) will remove it completely in Python 3.12 – currently mitigated by the use of [pyasyncore](https://pypi.org/project/pyasyncore/))
9898
- Full feature parity on different platforms (e.g., live menu updating; monitoring network status)
9999
- Clickable account authorisation notifications
100100
- STARTTLS for IMAP?

requirements.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ pystray
55
pywebview; sys_platform != 'win32' # specify platform to avoid double requirement error with older pip versions
66
timeago
77

8+
# provide the previously standard library module `asyncore`, removed in Python 3.12 (https://peps.python.org/pep-0594/)
9+
pyasyncore; python_version >= '3.12'
10+
811
# used to improve menu bar interaction, provide native notifications, handle system events and output to unified logging
912
pyobjc-framework-Cocoa; sys_platform == 'darwin'
1013
pyobjc-framework-SystemConfiguration; sys_platform == 'darwin'

0 commit comments

Comments
 (0)