Skip to content

Commit 058a8df

Browse files
committed
Fixed remaining broken tests
1 parent ac9f820 commit 058a8df

File tree

1 file changed

+19
-12
lines changed

1 file changed

+19
-12
lines changed

sqlite_utils/db.py

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3010,19 +3010,26 @@ def build_insert_queries_and_params(
30103010
extracts = resolve_extracts(extracts)
30113011

30123012
# Build a row-list ready for executemany-style flattening
3013-
values: list[list] = []
3014-
for record in chunk:
3015-
row_vals = []
3016-
for col in all_columns:
3017-
if col == hash_id:
3018-
row_vals.append(hash_record(record, hash_id_columns))
3019-
continue
3013+
values: List[list] = []
30203014

3021-
val = record.get(col)
3022-
if val is None and not_null and col in not_null:
3023-
val = ""
3024-
row_vals.append(jsonify_if_needed(val))
3025-
values.append(row_vals)
3015+
for record in chunk:
3016+
record_values = []
3017+
for key in all_columns:
3018+
value = jsonify_if_needed(
3019+
record.get(
3020+
key,
3021+
(
3022+
None
3023+
if key != hash_id
3024+
else hash_record(record, hash_id_columns)
3025+
),
3026+
)
3027+
)
3028+
if key in extracts:
3029+
extract_table = extracts[key]
3030+
value = self.db[extract_table].lookup({"value": value})
3031+
record_values.append(value)
3032+
values.append(record_values)
30263033

30273034
columns_sql = ", ".join(f"[{c}]" for c in all_columns)
30283035
placeholder_expr = ", ".join(conversions.get(c, "?") for c in all_columns)

0 commit comments

Comments
 (0)