Fix type warning for pipe.stdout possibly being None

simonw · claude · simonw · commit cb172edca0dc · 2025-12-16T16:22:07.000-08:00
Add conditional check before calling .read() on pipe.stdout since Popen can return None for stdout. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
diff --git a/docs/conf.py b/docs/conf.py
@@ -79,7 +79,7 @@ def linkcode_resolve(domain, info):
 #
 # The short X.Y version.
 pipe = Popen("git describe --tags --always", stdout=PIPE, shell=True)
-git_version = pipe.stdout.read().decode("utf8")
+git_version = pipe.stdout.read().decode("utf8") if pipe.stdout else ""
 
 if git_version:
     version = git_version.rsplit("-", 1)[0]

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ def linkcode_resolve(domain, info):`
`79`	`79`	`#`
`80`	`80`	`# The short X.Y version.`
`81`	`81`	`pipe = Popen("git describe --tags --always", stdout=PIPE, shell=True)`
`82`		`-git_version = pipe.stdout.read().decode("utf8")`
	`82`	`+git_version = pipe.stdout.read().decode("utf8") if pipe.stdout else ""`
`83`	`83`
`84`	`84`	`if git_version:`
`85`	`85`	`version = git_version.rsplit("-", 1)[0]`