Small bug-fixes and improvements

Author: simonwep

src/main/java/express/http/response/Response.java

@@ -35,11 +35,12 @@ public class Response {
 
   {
     // Initialize with default data
-    contentType = MediaType._txt.getMIME();
-    isClose = false;
-    contentLength = 0;
-    status = 200;
-    LOGGER = Logger.getLogger(getClass().getSimpleName());
+    this.contentType = MediaType._txt.getMIME();
+    this.isClose = false;
+    this.contentLength = 0;
+    this.status = 200;
+    this.LOGGER = Logger.getLogger(getClass().getSimpleName());
+    this.LOGGER.setUseParentHandlers(false); // Disable default console log
   }
 
   public Response(HttpExchange exchange) {
@@ -198,8 +199,7 @@ public boolean sendAttachment(Path file) {
     String dispo = "attachment; filename=\"" + file.getFileName() + "\"";
     setHeader("Content-Disposition", dispo);
 
-    send(file);
-    return true;
+    return send(file);
   }
 
   /**
@@ -235,6 +235,8 @@ public boolean send(Path file) {
 
     } catch (IOException e) {
       LOGGER.log(Level.INFO, "Failed to pipe file to outputstream.", e);
+      close();
+      return false;
     }
 
     close();
@@ -249,7 +251,10 @@ public boolean isClosed() {
   }
 
   /**
-   * @return The logger from this reponse object.
+   * Returns the logger which is concered for this Response object.
+   * There is no default-handler active, if you want to log it you need to set an handler.
+   *
+   * @return The logger from this Response object.
    */
   public Logger getLogger() {
     return LOGGER;

src/main/java/express/middleware/FileProvider.java

@@ -26,6 +26,11 @@ final class FileProvider implements HttpRequest {
   private FileProviderOptions OPTIONS;
   private String ROOT;
 
+  {
+    this.LOGGER = Logger.getLogger(this.getClass().getSimpleName());
+    this.LOGGER.setUseParentHandlers(false);  // Disable default console log
+  }
+
   FileProvider(String root, FileProviderOptions options) throws IOException {
     File rootDir = new File(root);
 
@@ -34,7 +39,6 @@ final class FileProvider implements HttpRequest {
 
     this.ROOT = rootDir.getAbsolutePath();
     this.OPTIONS = options;
-    this.LOGGER = Logger.getLogger(this.getClass().getSimpleName());
   }
 
   @Override
@@ -127,8 +131,12 @@ private String getBaseName(Path path) {
     return index == -1 ? name : name.substring(0, index);
   }
 
+
   /**
-   * @return The logger from this FileProvider instance.
+   * Returns the logger which is concered for this FileProvilder object.
+   * There is no default-handler active, if you want to log it you need to set an handler.
+   *
+   * @return The logger from this FileProvilder object.
    */
   public Logger getLogger() {
     return LOGGER;