Refactor pac template

Author: silug

manifests/service/pac.pp

@@ -36,15 +36,50 @@
       },
     )
   } else {
+    # Build configuration content for the PAC service
+    $_base_content = [
+      '# sssd::service::pac',
+      '[pac]',
+    ]
+
+    # Add conditional parameters if defined
+    if $description {
+      $_description_entries = ["description = ${description}"]
+    } else {
+      $_description_entries = []
+    }
+
+    if $debug_level {
+      $_debug_level_entries = ["debug_level = ${debug_level}"]
+    } else {
+      $_debug_level_entries = []
+    }
+
+    $_debug_timestamps_entries = $debug_timestamps ? {
+      true  => ['debug_timestamps = true'],
+      false => ['debug_timestamps = false'],
+    }
+
+    $_debug_microseconds_entries = $debug_microseconds ? {
+      true  => ['debug_microseconds = true'],
+      false => ['debug_microseconds = false'],
+    }
+
+    if !$allowed_uids.empty {
+      $_allowed_uids_entries = ["allowed_uids = ${allowed_uids.join(',')}"]
+    } else {
+      $_allowed_uids_entries = []
+    }
+
+    # Combine all configuration entries in the expected order
+    $_all_entries = $_base_content + $_description_entries + $_debug_level_entries + $_debug_timestamps_entries + $_debug_microseconds_entries + $_allowed_uids_entries
+
+    $_final_content = $_all_entries.join("\n")
+
     $_content = epp(
       "${module_name}/service/pac.epp",
       {
-        'description'        => $description,
-        'debug_level'        => $debug_level,
-        'debug_timestamps'   => $debug_timestamps,
-        'debug_microseconds' => $debug_microseconds,
-        'allowed_uids'       => $allowed_uids,
-        'custom_options'     => $custom_options,
+        'content' => $_final_content,
       },
     )
   }

templates/service/pac.epp

@@ -1,22 +1,4 @@
-<% |
-  Optional[String]             $description,
-  Optional[Sssd::DebugLevel]   $debug_level,
-  Boolean                      $debug_timestamps,
-  Boolean                      $debug_microseconds,
-  Array[String]                $allowed_uids,
-  Optional[Hash]               $custom_options,
+<%- |
+  String $content,
 | -%>
-
-# sssd::service::pac
-[pac]
-<% if $description { -%>
-description = <%= $description %>
-<% } -%>
-<% if $debug_level { -%>
-debug_level = <%= $debug_level %>
-<% } -%>
-debug_timestamps = <%= $debug_timestamps %>
-debug_microseconds = <%= $debug_microseconds %>
-<% unless $allowed_uids.empty { -%>
-allowed_uids = <%= Array($allowed_uids).join(',') %>
-<% } -%>
+<%= $content %>