Fix metadata object refresh and remove trailing commas

Author: adriaandotcom

src/default.js

@@ -117,8 +117,8 @@
       return Array.isArray(csv)
         ? csv
         : isString(csv) && csv.length
-        ? csv.split(/, ?/)
-        : [];
+          ? csv.split(/, ?/)
+          : [];
     };
 
     var isObject = function (object) {
@@ -205,8 +205,8 @@
       defaultNamespace;
 
     /** if metadata **/
-    var metadataObject = window[namespace + "_metadata"];
     var appendMetadata = function (metadata, data) {
+      var metadataObject = window[namespace + "_metadata"];
       if (isObject(metadataObject)) metadata = assign(metadata, metadataObject);
       var metadataCollectorFunction = window[metadataCollector];
       if (!isFunction(metadataCollectorFunction)) return metadata;

test/test-append-metadata.js

@@ -0,0 +1,25 @@
+const { expect } = require("chai");
+
+describe("appendMetadata", function () {
+  it("reloads sa_metadata each call", function () {
+    const namespace = "sa";
+    const window = {};
+
+    const isObject = (obj) => obj && obj.constructor === Object;
+    const assign = (target, source) => Object.assign(target, source);
+
+    const appendMetadata = function (metadata, data) {
+      const metadataObject = window[namespace + "_metadata"];
+      if (isObject(metadataObject)) metadata = assign(metadata, metadataObject);
+      return metadata;
+    };
+
+    window[namespace + "_metadata"] = { a: 1 };
+    let metadata = appendMetadata({}, {});
+    expect(metadata).to.deep.equal({ a: 1 });
+
+    window[namespace + "_metadata"] = { b: 2 };
+    metadata = appendMetadata({}, {});
+    expect(metadata).to.deep.equal({ b: 2 });
+  });
+});