Different attributes per telemetry event

Author: LeartS

lib/commanded/event_store.ex

@@ -48,28 +48,18 @@ defmodule OpentelemetryCommanded.EventStore do
   end
 
   def handle_start([_, _, action, _type], _measurements, meta, _) do
-    event = meta.event
-
-    safe_context_propagation(event.metadata["trace_ctx"])
-
-    attributes = [
-      "commanded.application": meta.application,
-      "commanded.causation_id": event.causation_id,
-      "commanded.correlation_id": event.correlation_id,
-      "commanded.event": event.event_type,
-      "commanded.event_id": event.event_id,
-      "commanded.event_number": event.event_number,
-      "commanded.stream_id": event.stream_id,
-      "commanded.stream_version": event.stream_version
-    ]
+    # TODO: how do we keep the trace context for telemetry events that don't have this value?
+    if trace_ctx = get_in(meta, [:event, Access.key!(:metadata), "trace_ctx"]) do
+      safe_context_propagation(trace_ctx)
+    end
 
     OpentelemetryTelemetry.start_telemetry_span(
       @tracer_id,
       "commanded.event_store.#{action}",
       meta,
       %{
         kind: :internal,
-        attributes: attributes
+        attributes: attributes(action, meta)
       }
     )
   end
@@ -101,4 +91,26 @@ defmodule OpentelemetryCommanded.EventStore do
 
     OpentelemetryTelemetry.end_telemetry_span(@tracer_id, meta)
   end
+
+  def attributes(:ack_event, meta) do
+    event = meta.event
+    [
+      "commanded.application": meta.application,
+      "commanded.causation_id": event.causation_id,
+      "commanded.correlation_id": event.correlation_id,
+      "commanded.event": event.event_type,
+      "commanded.event_id": event.event_id,
+      "commanded.event_number": event.event_number,
+      "commanded.stream_id": event.stream_id,
+      "commanded.stream_version": event.stream_version
+    ]
+  end
+
+  def attributes(telemetry_event, meta) do
+    # Generic default: put all scalar metadata in span attributes
+    for {meta_key, meta_val} <- meta, is_binary(meta_val) or is_number(meta_val), into: [] do
+      {"commanded.#{meta_key}", meta_val}
+    end
+  end
+
 end